Closed Bug 1023604 Opened 6 years ago Closed 5 years ago

Add HiDPI webrtc notification icons for Windows and Linux

Categories

(Firefox :: Theme, defect)

x86
Windows 7
defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 41
Iteration:
41.3 - Jun 29
Tracking Status
firefox40 --- verified
firefox41 --- verified

People

(Reporter: Dolske, Assigned: jaws)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

This is a somewhat arbitrary breakdown of bug 1023511.

Implement Windows HiDPI support for doorhanger UI, specifically:

  - Various main icon for doorhanger content
  - Various anchor icons for doorhangers

(1023511 also listed the arrowpanel arrow, but I see that's already SVG on Windows and Linux, so no further change should be needed.)

Note that we never added OS X Retina images for some doorhangers, which is tracked by bug 1021958. We can do that for Windows here or under bug 1023517.
Hey Stephen, can you provide HiDPI notification icons for Windows (and Linux) here? I think the ones in the OSX folder have Yosemite color schemes to them.

These would be:
Geolocation-16@2x.png
Geolocation-64@2x.png
notification-16@2x.png
notification-64@2x.png
pointerLock-16@2x.png
pointerLock-64@2x.png
Push-16@2x.png (same as geolocation currently)
Push-64@2x.png (same as geolocation currently)
urlbar-popup-blocked@2x.png
webRTC-shareDevice-16@2x.png
webRTC-shareDevice-64@2x.png
webRTC-shareMicrophone-16@2x.png
webRTC-shareMicrophone-64@2x.png
Flags: needinfo?(shorlander)
(In reply to (Limited avail. until June 16)  Jared Wein [:jaws] (please needinfo? me) from comment #1)
> webRTC-shareDevice-16@2x.png
> webRTC-shareDevice-64@2x.png
> webRTC-shareMicrophone-16@2x.png
> webRTC-shareMicrophone-64@2x.png

It looks like we are using the shared icons out of browser/themes/shared/webrtc and they already have @2x images. The theme specific versions look unused to me?
Flags: needinfo?(shorlander) → needinfo?(jaws)
Attached patch PatchSplinter Review
This patch adds support for the webRTC icons which were all the same per platform. Other icons, like the geolocation-16.png, are different when comparing Windows and OSX.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Attachment #8622013 - Flags: review?(gijskruitbosch+bugs)
Iteration: --- → 41.3 - Jun 29
Points: --- → 3
Flags: qe-verify+
Flags: firefox-backlog+
Comment on attachment 8622013 [details] [diff] [review]
Patch

Review of attachment 8622013 [details] [diff] [review]:
-----------------------------------------------------------------

Thousand curses on splinter for totally butchering your hg renames. But yeah, this looks awright.
Attachment #8622013 - Flags: review?(gijskruitbosch+bugs) → review+
Can we change the title of this bug and file separate followup bugs for the other icons, btw? :-)
https://hg.mozilla.org/mozilla-central/rev/899480708490
https://hg.mozilla.org/mozilla-central/rev/dabc93a5eff1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Summary: Implement Windows HiDPI theme for doorhanger UI → Add HiDPI webrtc notification icons for Windows and Linux
QA Contact: cornel.ionce
The HiDPI webrtc notification icons are successfully updated using latest Nightly (build ID: 20150621030204) on Windows 7 64-bit, Windows 8.1 64-bit and Ubuntu 14.04 32bit.
Status: RESOLVED → VERIFIED
Attached patch Patch for 40Splinter Review
Approval Request Comment
[Feature/regressing bug #]: Windows 10 HiDPI
[User impact if declined]: HiDPI icons on Windows are blurry
[Describe test coverage new/current, TreeHerder]: on mozilla-central for much of 41-nightly
[Risks and why]: none expected 
[String/UUID change made/needed]: none

https://hg.mozilla.org/try/pushloghtml?changeset=71084a9edf1e
Attachment #8627209 - Flags: approval-mozilla-beta?
Comment on attachment 8627209 [details] [diff] [review]
Patch for 40

Straightforward visual fix. Beta+
Attachment #8627209 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Also tested and verified using Firefox 40 beta 2, build ID: 20150706172413.
You need to log in before you can comment on or make changes to this bug.