Closed
Bug 1023734
Opened 12 years ago
Closed 12 years ago
aboutaccounts show() and hide() methods are error prone
Categories
(Firefox :: Firefox Accounts, defect)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 33
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
|
5.14 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
The show() and hide() methods in about:accounts are error prone - it's quite easy to mess it up and end up with incorrect divs shown or hidden.
This patch makes show take one mandatory param - the top-level id to show, and an optional second param - the id of a child under the top-level that will be shown. All other relevant entries are hidden.
This patch was in another bug and is no longer necessary in that bug, so I split it out here - but I still think the patch is worthwhile.
Attachment #8438233 -
Flags: review?(ttaubert)
|
||
Updated•12 years ago
|
Attachment #8438233 -
Flags: review?(ttaubert) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
|
|
||
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•8 years ago
|
Product: Core → Firefox
|
||
Updated•8 years ago
|
Target Milestone: mozilla33 → Firefox 33
You need to log in
before you can comment on or make changes to this bug.
Description
•