Closed Bug 1023734 Opened 8 years ago Closed 8 years ago

aboutaccounts show() and hide() methods are error prone

Categories

(Firefox :: Firefox Accounts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 33

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

The show() and hide() methods in about:accounts are error prone - it's quite easy to mess it up and end up with incorrect divs shown or hidden.

This patch makes show take one mandatory param - the top-level id to show, and an optional second param - the id of a child under the top-level that will be shown.  All other relevant entries are hidden.

This patch was in another bug and is no longer necessary in that bug, so I split it out here - but I still think the patch is worthwhile.
Attachment #8438233 - Flags: review?(ttaubert)
Attachment #8438233 - Flags: review?(ttaubert) → review+
Thanks!

https://hg.mozilla.org/integration/fx-team/rev/4bfd917b4839
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/4bfd917b4839
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Firefox
Target Milestone: mozilla33 → Firefox 33
You need to log in before you can comment on or make changes to this bug.