102377 - Chatzilla does not handle server passwords

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Francisco León]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4+) Gecko/20010921
BuildID:    2001092106

IRC accepts a /server ircserver port password
Chatzilla does too, but the password is not being supplied
Talked with rginda on irc, fix should be trivial.

Reproducible: Always
Steps to Reproduce:
1./server something port password


Actual Results:  No password goes through

Expected Results:  Opposite

Comment 1

[Francisco León]

I am just learning, but the problem may be in one of these lines in handlers.js
var pass = (ary[2]) ? ary[2] : ""; (line 1202)

    if (!ary[2])                   (line 1207)
        ary[2] = 6667;
new CIRCNetwork (ary[1], [{name: ary[1], port: ary[2]}],  (line 1228)
                             client.eventPump);
    else
        net.serverList = [{name: ary[1], port: ary[2]}];

    client.onInputAttach ({inputData: ary[1] + " " + pass});

I think the problem is that ari[2] is sharing its value between the password and
the port. If my thought seems stupid, it probably is :)

Comment 2

[Robert Ginda]

That does indeed look like part of the problem.  pass is the third capture in
the  pattern, and should be ary[3].  There is mixup later in the code, confusing
pass with password.  I'll include these to fixes in the upcoming 0.8.5 release.

Thanks for spotting the array confusion.

Comment 3

[Robert Ginda]

The chatzilla 0.8.5 branch has landed, if you believe this bug is not actually
fixed, and you are sure you are running chatzilla 0.8.5-rc1, please reopen the
bug for further consideration.