Closed
Bug 1023784
Opened 10 years ago
Closed 10 years ago
[7715][calendar] in calendar the string "Offline Calendar " can't be switched synchronously between Bengali and English
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: yaoyao.wu, Assigned: mmedeiros)
References
()
Details
(Keywords: late-l10n)
Attachments
(4 files)
as attachment calen-1.png show, default calendar account name "Offline calendar" can't be translated synchronously
as attachment cal-2.png show : in a new event the "Offline calendar" string can't be translated synchronously
Comment 3•10 years ago
|
||
Miller, you can probably look to email for some guidance on this one. The common mail folders like 'Inbox' and 'Sent' are translated into the target locale when you switch languages. Can you take a look at doing that for 'Offline calendar'?
Flags: needinfo?(doliver) → needinfo?(mmedeiros)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mmedeiros
Flags: needinfo?(mmedeiros)
Target Milestone: --- → 2.0 S4 (20june)
Assignee | ||
Comment 4•10 years ago
|
||
what are the steps to reproduce the bug? I was not able to reproduce the screenshot 1 (settings drawer) and markup looks correct (contains the [data-l10n-id] attribute). On the create event I got a different behavior (reminders, Offline calendar and date format doesn't update).
Flags: needinfo?(yaoyao.wu)
Assignee | ||
Comment 5•10 years ago
|
||
PS: I tried on hamachi with eng build 1.4 Gaia 7fc73d4cb1bece31f50e8ccf6fb98af3984a9ebf Gecko https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/bcd308fbbf38 BuildID 20140612000202 Version 30.0
Comment 6•10 years ago
|
||
(In reply to Miller Medeiros [:millermedeiros] from comment #4) > On the create event I got a different behavior > (reminders, Offline calendar and date format doesn't update). Yep, those were the parts I noticed.
(In reply to Miller Medeiros [:millermedeiros] from comment #4) > what are the steps to reproduce the bug? I was not able to reproduce the > screenshot 1 (settings drawer) and markup looks correct (contains the > [data-l10n-id] attribute). On the create event I got a different behavior > (reminders, Offline calendar and date format doesn't update). Steps to Reproduce bug described in attachment 8438321 [details]-calen-1.png 1 Switching language to Bengali 2 get into the calendar application -Set 3 Switch the language to English again 4 get into calendar application again -Set
Flags: needinfo?(yaoyao.wu)
Assignee | ||
Comment 8•10 years ago
|
||
I found out that the event details page also wasn't updating the calendar name and reminders and fixed it as well. I fixed the calendar name, date, time and reminders L10n on the create/edit/view event pages. I was not able to reproduce the https://bugzilla.mozilla.org/attachment.cgi?id=8438321 (markup on latest build looks correct) - yaoyao.wu is probably testing a different build. PS: this issue also affects 2.0 and I'll need to provide a different patch for it.
Attachment #8440196 -
Flags: review?(gaye)
Comment 9•10 years ago
|
||
Comment on attachment 8440196 [details] [review] Link to Github pull-request: 1.4 branch A few nits on GH but looks reasonable otherwise. Thanks!
Attachment #8440196 -
Flags: review?(gaye) → review+
Assignee | ||
Comment 10•10 years ago
|
||
basically same changes as previous patch but targeting master instead of branch v1.4 (this patch can/should be uplifted to 2.0 as well)
Attachment #8442522 -
Flags: review?(gaye)
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
Updated•10 years ago
|
Attachment #8440196 -
Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20518 → Link to Github pull-request: 1.4 branch
Updated•10 years ago
|
Attachment #8442522 -
Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20717 → Link to Github pull-request: 2.0/master branches
Updated•10 years ago
|
Attachment #8442522 -
Flags: review?(gaye) → review+
Assignee | ||
Comment 11•10 years ago
|
||
landed on master: https://github.com/mozilla-b2g/gaia/commit/6adf6be7dcbf5f5e320df979fb83d5a624783378 (still needs to uplift to v2.0 branch and merge the other PR to v1.4 branch after approval)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8440196 [details] [review] Link to Github pull-request: 1.4 branch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): this is not a regression, behavior is the same since March 2013. [User impact] if declined: should be low since it only happens when user changes the language (should not happen that often) and only if calendar app is running. [Testing completed]: manual test and unit tests to check if L10n attributes are added to the elements. [Risk to taking this patch] (and alternatives if risky): low risk since I targeted the v1.4 directly and checked for conflicts and executed tests, did not change that much from old logic. [String changes made]: none
Attachment #8440196 -
Flags: approval-gaia-v1.4?(doliver)
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8440196 [details] [review] Link to Github pull-request: 1.4 branch this needs to be merged into v1.4
Attachment #8440196 -
Flags: approval-gaia-v1.4?(doliver) → approval-gaia-v1.4?
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8440196 [details] [review] Link to Github pull-request: 1.4 branch removing the approval flag since this is a blocker and I'll just got ahead and merge it.
Attachment #8440196 -
Flags: approval-gaia-v1.4?
Assignee | ||
Comment 15•10 years ago
|
||
landed on v1.4 branch: https://github.com/mozilla-b2g/gaia/commit/3419a1f68aaf64a0688685bce42d4173b6125597
Assignee | ||
Comment 16•10 years ago
|
||
landed on v2.0 branch: https://github.com/mozilla-b2g/gaia/commit/27f7653f6d31935a2f0ae4c61c5e67f7b459352a
Updated•10 years ago
|
Comment 17•10 years ago
|
||
[Environment] Gaia 2248c0367661db9332f70f37055e1a8176f5f612 Gecko https://hg.mozilla.org/releases/mozilla-aurora/rev/44d31566a3a6 BuildID 20140629160202 Version 32.0a2 ro.build.version.incremental=108 ro.build.date=Tue Jun 10 19:40:40 CST 2014 [Result] Pass
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Flags: in-moztrap?(bzumwalt)
Comment 18•10 years ago
|
||
New test case needs to be written to address bug.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Comment 19•10 years ago
|
||
Test case created in moztrap: https://moztrap.mozilla.org/manage/case/14335/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(bzumwalt)
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•