Closed Bug 1023784 Opened 10 years ago Closed 10 years ago

[7715][calendar] in calendar the string "Offline Calendar " can't be switched synchronously between Bengali and English

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

VERIFIED FIXED
2.0 S4 (20june)
blocking-b2g 1.4+
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: yaoyao.wu, Assigned: mmedeiros)

References

()

Details

(Keywords: late-l10n)

Attachments

(4 files)

Attached image calen-1.png
as attachment calen-1.png show, default calendar account name "Offline calendar" can't be translated synchronously
Attached image cal-2.png
as attachment cal-2.png show : in a new event the "Offline calendar" string  can't be translated synchronously
blocking-b2g: 1.4? → 1.4+
Keywords: late-l10n
Dylan

Please review for calendar
Flags: needinfo?(doliver)
Miller, you can probably look to email for some guidance on this one. The common mail folders like 'Inbox' and 'Sent' are translated into the target locale when you switch languages. Can you take a look at doing that for 'Offline calendar'?
Flags: needinfo?(doliver) → needinfo?(mmedeiros)
Assignee: nobody → mmedeiros
Flags: needinfo?(mmedeiros)
Target Milestone: --- → 2.0 S4 (20june)
what are the steps to reproduce the bug? I was not able to reproduce the screenshot 1 (settings drawer) and markup looks correct (contains the [data-l10n-id] attribute). On the create event I got a different behavior (reminders, Offline calendar and date format doesn't update).
Flags: needinfo?(yaoyao.wu)
PS: I tried on hamachi with eng build 1.4

Gaia      7fc73d4cb1bece31f50e8ccf6fb98af3984a9ebf
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/bcd308fbbf38
BuildID   20140612000202
Version   30.0
(In reply to Miller Medeiros [:millermedeiros] from comment #4)
>  On the create event I got a different behavior
> (reminders, Offline calendar and date format doesn't update).

Yep, those were the parts I noticed.
(In reply to Miller Medeiros [:millermedeiros] from comment #4)
> what are the steps to reproduce the bug? I was not able to reproduce the
> screenshot 1 (settings drawer) and markup looks correct (contains the
> [data-l10n-id] attribute). On the create event I got a different behavior
> (reminders, Offline calendar and date format doesn't update).

Steps to Reproduce bug described in attachment 8438321 [details]-calen-1.png
1 Switching language to Bengali 
2 get into the calendar application -Set
3 Switch the language to English again 
4 get into  calendar application again  -Set
Flags: needinfo?(yaoyao.wu)
I found out that the event details page also wasn't updating the calendar name and reminders and fixed it as well. I fixed the calendar name, date, time and reminders L10n on the create/edit/view event pages.

I was not able to reproduce the https://bugzilla.mozilla.org/attachment.cgi?id=8438321 (markup on latest build looks correct) - yaoyao.wu is probably testing a different build.

PS: this issue also affects 2.0 and I'll need to provide a different patch for it.
Attachment #8440196 - Flags: review?(gaye)
Comment on attachment 8440196 [details] [review]
Link to Github pull-request: 1.4 branch

A few nits on GH but looks reasonable otherwise. Thanks!
Attachment #8440196 - Flags: review?(gaye) → review+
basically same changes as previous patch but targeting master instead of branch v1.4 (this patch can/should be uplifted to 2.0 as well)
Attachment #8442522 - Flags: review?(gaye)
Attachment #8440196 - Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20518 → Link to Github pull-request: 1.4 branch
Attachment #8442522 - Attachment description: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20717 → Link to Github pull-request: 2.0/master branches
Attachment #8442522 - Flags: review?(gaye) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/6adf6be7dcbf5f5e320df979fb83d5a624783378

(still needs to uplift to v2.0 branch and merge the other PR to v1.4 branch after approval)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8440196 [details] [review]
Link to Github pull-request: 1.4 branch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): this is not a regression, behavior is the same since March 2013.
[User impact] if declined: should be low since it only happens when user changes the language (should not happen that often) and only if calendar app is running.
[Testing completed]: manual test and unit tests to check if L10n attributes are added to the elements.
[Risk to taking this patch] (and alternatives if risky): low risk since I targeted the v1.4 directly and checked for conflicts and executed tests, did not change that much from old logic.
[String changes made]: none
Attachment #8440196 - Flags: approval-gaia-v1.4?(doliver)
Comment on attachment 8440196 [details] [review]
Link to Github pull-request: 1.4 branch

this needs to be merged into v1.4
Attachment #8440196 - Flags: approval-gaia-v1.4?(doliver) → approval-gaia-v1.4?
Comment on attachment 8440196 [details] [review]
Link to Github pull-request: 1.4 branch

removing the approval flag since this is a blocker and I'll just got ahead and merge it.
Attachment #8440196 - Flags: approval-gaia-v1.4?
[Environment]
Gaia      2248c0367661db9332f70f37055e1a8176f5f612
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/44d31566a3a6
BuildID   20140629160202
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014

[Result]
Pass
Status: RESOLVED → VERIFIED
Flags: in-moztrap?(bzumwalt)
New test case needs to be written to address bug.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Test case created in moztrap:

https://moztrap.mozilla.org/manage/case/14335/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(bzumwalt)
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: