1023864 - disabling of jacuzzis appears to be broken

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

I noticed this while trying to do some l10n nightlies in staging. In my master.cfg I set:
master_common.prioritizeBuilders.check_jacuzzis = False


But my jobs still wouldn't start, even after a full master restart. I get messages like:
2014-06-11 06:19:39-0700 [-] prioritizeBuilders: 0.01s using up to first 2 builders:
2014-06-11 06:19:39-0700 [-] prioritizeBuilders: 0.01s important builder Firefox mozilla-central linux64 l10n nightly (p = (0, 40, 1402492662.372122))
2014-06-11 06:19:39-0700 [-] prioritizeBuilders: 0.01s found 1 important builder(s): ['Firefox mozilla-central linux64 l10n nightly']
2014-06-11 06:19:39-0700 [-] prioritizeBuilders: 0.01s finished prioritization
2014-06-11 06:19:39-0700 [-] JacuzziAllocator 65680144: checking cache for builder Firefox mozilla-central linux64 l10n nightly
2014-06-11 06:19:39-0700 [-] JacuzziAllocator 65680144: cache miss
2014-06-11 06:19:39-0700 [-] JacuzziAllocator 65680144: fetching http://jacuzzi-allocator.pub.build.mozilla.org/v1/builders/Firefox%20mozilla-central%20linux64%20l10n%20nightly
2014-06-11 06:19:39-0700 [-] JacuzziAllocator 65680144: slaves: set([u'bld-linux64-spot-030', u'bld-linux64-spot-031', u'bld-linux64-spot-329', u'bld-linux64-spot-330'])
2014-06-11 06:19:39-0700 [-] <Builder ''Firefox mozilla-central linux64 l10n nightly'' at 34996664>: want to start build, but we don't have a remote
2014-06-11 06:19:39-0700 [-] <Builder ''Firefox mozilla-central linux64 l10n nightly'' at 34996664>: got assignments: {}

I tried disabling it by getting rid of prioritizeBuilders, but that didn't work either. Eventually I ripped out the @J usages in misc.py to do it.

Comment 1

[Chris AtLee [:catlee]]

Attachment: add jacuzzi_enabled flag to jacuzzi; stop waiting for aws slaves

we'll set jacuzzi_enabled = False in master.cfg.

we don't have any mix of in-house and AWS slaves any more, so it doesn't make sense to wait for them.

Comment 2

[Chris AtLee [:catlee]]

Attachment: add support for ENABLE_JACUZZIS flag in localconfig