1023948 - TBPL support for Android 2.2 on armv6 builds with Android 2.3 tests on emulators

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1023948.patch

So this patch doesn't work because it matches to Android 2.2 Armv6.

Not sure what I should do to fix this, perhaps change the name in  buildbot configs instead so it's a better and less confusing name.  Like "fred". Because android-2-2-armv6-on2.3emulator on ix is really too long.

Comment 2

[Ed Morley [:emorley]]

The row that jobs display on in TBPL is normally the platform on which the job ran (eg mochitest-1 that ran on Windows 7), rather than the platform on which the binary was generated. As such, shouldn't these jobs go on the Android 2.3 row? Or am I mis-understanding what these jobs are?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8438536 [details] [diff] [review]
bug1023948.patch

Per our IRC conversation, we're going to rename the jobs in buildbot to better fit the already-existing naming conventions. We'll revisit this patch once that work is completed.

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1023948.patch

This patch works but the line is too long in tbpl "Opt" gets cut off 
so perhaps "Android 2.3 Emulator" only?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8441555 [details] [diff] [review]
bug1023948.patch

On the TBPL side, we don't include emulator in the name for the existing 2.3 (non-armv6) tests, so I think we should just drop it - i.e. "android-2-3-armv6" and "Android 2.3 Armv6". We can't really do anything about the "Opt" part that gets added to the name anyway as that comes from a different section of code that affects all jobs.

In a perfect world, we would also name the jobs on the buildbot side with the armv6 before emulator in the name to make the regex a bit tidier, but that's not a big deal if that stays as-is as I'm sure you'd prefer avoiding that churn at this point :)

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1023948.patch

This looks good on ash which currently has tests running.  I also changed the name in the buildbot configs to match in this morning's reconfig.

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8442914 [details] [diff] [review]
bug1023948.patch

Review of attachment 8442914 [details] [diff] [review]:
-----------------------------------------------------------------

(Ryan is on PTO for the next few days)
lgtm - thank you :-)

Comment 8

[Kim Moir [:kmoir] ET]

:edmorley can you please land this for me I don't have commit rights on tbpl

Comment 9

[Ed Morley [:emorley]]

Yeah no problem :-)

remote:   https://hg.mozilla.org/webtools/tbpl/rev/efa47b500dfb

I'll hopefully push tomorrow - but depends on the state of bug 1027031, which is possibly causing Tomcat issues running mcMerge.

Comment 10

[Ed Morley [:emorley]]

If it helps, bug 1023948 can land whenever, TBPL won't break if the ui-patches aren't pushed to prod yet :-)

Comment 11

[Kim Moir [:kmoir] ET]

The ui looks very confusing right now because the 2.3 and 2.3 armv6 test are merged together into one line. That's why I was holding off.

Comment 12

[Ed Morley [:emorley]]

Ah ok - pushed :-)