1023983 - Don't show tracebacks in validation results

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[Kumar McMillan [:kumar]]

Attachment: Screen Shot 2014-06-11 at 12.08.47 PM.png

If the validator raises an exception, the Marketplace shows the full traceback in app submission and the validation tester. Let's not show the traceback because there's a chance that sensitive info might leak.

STR
- cause the validator to raise an exception
- upload an app or use the tester

It should fail with 'unexpected internal error' or something like that.

See bug 1023490 for an example

Comment 1

[Mark Striemer [:mstriemer]]

Looks like we're exposing tracebacks everywhere except for development. I'll switch that around.

$ git grep EXPOSE_VALIDATOR_TRACEBACKS
lib/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = False
mkt/developers/views.py:    if not settings.EXPOSE_VALIDATOR_TRACEBACKS:
sites/altdev/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/dev/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/identitystage/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/landfill/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/paymentsalt/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/prod/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True
sites/stage/settings_base.py:EXPOSE_VALIDATOR_TRACEBACKS = True

Comment 2

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/pull/2189

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/3579a97f906dd22e908daf6c375caf05f89338af

Comment 4

[Iulian Timis]

Issue is still reproducing in https://marketplace.allizom.org/developers/validator on FF33 (Win 7). On -dev, the app passes validation with no error
Please see screencast http://screencast.com/t/Rz8LVD5NNt17

Comment 5

[Mark Striemer [:mstriemer]]

The stage deploy failed last week, this is on stage now. Unfortunately the addon we used for the traceback no longer errors though.

Comment 6

[Iulian Timis]

Can you please provide us an app that raises an exception in order to verify this issue? Thank you!

Comment 7

[Mark Striemer [:mstriemer]]

I unfortunately don't know of an app that will raise an error. Since this was just a config change and it worked locally I'm thinking we can leave it and open a new bug if it somehow shows up again later.