1024066 - webgl-1.0.3 conformance failure OES texture half float

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Walter Litwinczyk [:walter]]

http://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-texture-half-float.html

Some tests fail on central.

Comment 1

[Walter Litwinczyk [:walter]]

Attachment: oes_half_float_patch

Try: https://tbpl.mozilla.org/?tree=Try&rev=42914e96d93a

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8438718 [details] [diff] [review]
oes_half_float_patch

Review of attachment 8438718 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextValidate.cpp
@@ -1205,5 @@
>      case LOCAL_GL_UNSIGNED_BYTE:
>          validInput = (jsArrayType == -1 || jsArrayType == js::ArrayBufferView::TYPE_UINT8);
>          break;
>  
> -        // TODO: WebGL spec doesn't allow half floats to specified as UInt16.

Yep, we got this changed.

Comment 3

[Walter Litwinczyk [:walter]]

Attachment: oes_texture_half_float_pass.png

Comment 4

[Walter Litwinczyk [:walter]]

Attachment: oes_texture_half_float.png

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f6144466d92

Friendly reminder that your commit message should be summarizing what the patch is actually doing, not just restating the problem it's fixing. Thanks!
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f6144466d92