Closed
Bug 102413
Opened 23 years ago
Closed 23 years ago
nsIWebShell's GetURL using const PRUnichar**
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: adamlock)
References
Details
Attachments
(2 files)
|
2.64 KB,
patch
|
jag+mozilla
:
review+
|
Details | Diff | Splinter Review |
|
2.77 KB,
patch
|
jag+mozilla
:
review+
rpotts
:
superreview+
|
Details | Diff | Splinter Review |
Should not be const Needs to be fixed so we can use getter_Copies with an XPIDLString
|
||
Comment 2•23 years ago
|
||
Looks good, except that in mozilla/webshell/tests/viewer/nsBrowserWindow.cpp near where you made the change there you're leaking the PRUnichar* you're getting. Not necessarily part of this patch, but you may want to fix that while you're there (using nsXPIDLString and getter_Copies). r=jag
|
|
||
Updated•23 years ago
|
Attachment #52499 -
Flags: review+
*** Bug 102410 has been marked as a duplicate of this bug. ***
|
|
||
Comment 5•23 years ago
|
||
Comment on attachment 52507 [details] [diff] [review] Second patch with getter_Copies r=jag I like this :-)
Attachment #52507 -
Flags: review+
|
|
||
Comment 6•23 years ago
|
||
(Of course, I could point out that one could save that string copy by making ViewSource take const nsAString& instead of nsString, but that is really a different bug altogether, so I won't ;-) ).
|
||
Comment 7•23 years ago
|
||
Comment on attachment 52507 [details] [diff] [review] Second patch with getter_Copies sr=rpotts@netscape.com
Attachment #52507 -
Flags: superreview+
Fix is checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•