1024162 - Allow 'make test-perf' to operate with arbitrary Marionette ports

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

WebQA is setting up Flame devices with multiple devices per node.  Since more than once device will be operating per machine, they can't all use Marionette port 2828 (the default).

Instead, we'll have to dynamically setup adb port forwarding, and pass arbitrary port numbers to Marionette-based tools for them to use.

Therefore, we'll 'make test-perf' will need the ability to accept a Marionette port number and operate on that port; e.g., 'MARIONETTE_PORT=2929 make test-perf'.  It may already have this ability; I'm not sure.

Comment 1

[Hubert Figuiere [:hub]]

With the current state of the art, the forwarding is done by using a unique port on the host, that actually change everytime. This is already handled by the marionette JS runner.

Isn't that what you need?

Comment 2

[Jonathan Griffin (:jgriffin)]

(In reply to Hubert Figuiere [:hub] from comment #1)
> With the current state of the art, the forwarding is done by using a unique
> port on the host, that actually change everytime. This is already handled by
> the marionette JS runner.
> 
> Isn't that what you need?

Perhaps.  In our big Flame buildout, we will have multiple devices running on the same machine.  It will be necessary for the Jenkins jobs to pass either an adb serial number or a Marionette port to 'make test-perf', so that it knows which device to operate on.  Can we do that already?

Comment 3

[Hubert Figuiere [:hub]]

(In reply to Jonathan Griffin (:jgriffin) from comment #2)

> Perhaps.  In our big Flame buildout, we will have multiple devices running
> on the same machine.  It will be necessary for the Jenkins jobs to pass
> either an adb serial number or a Marionette port to 'make test-perf', so
> that it knows which device to operate on.  Can we do that already?

You can set ANDROID_SERIAL environment to the device serial (adb devices) and it will be picked automatically. We don't know the ports in advance as it change at each connection. But the forward is set with adb and adb honour this.

ADB_SERIAL=serial make test-perf

Comment 4

[Hubert Figuiere [:hub]]

I forgot to add: the ANDROID_SERIAL thing is documented since yesterday in MDN for the performance testing framework.

Comment 5

[Jonathan Griffin (:jgriffin)]

Thanks, that should be enough for us to get the tests running.

Comment 6

[Hubert Figuiere [:hub]]

Please let me know if you are having trouble with it. Thanks.