Closed Bug 1024271 Opened 6 years ago Closed 6 years ago
Win64 REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/svg/text/text
Length-3 .svg | image comparison (==), max difference: 4, number of differing pixels: 17
https://tbpl.mozilla.org/php/getParsedLog.php?id=41405495&tree=Date According to reftest analyzer there are some very small differences in a few characters, usually off by 1 in the red component. Maybe it just needs to be fuzzy?
A fuzzy annotation seems reasonable, yeah. The mismatch is only: > max difference: 4, number of differing pixels: 17 and it's all at the edges of characters. Ideally we should use fuzzy-if(), with whatever the right condition-name is for this platform.
Normally the fuzzy-if definitions are by toolkit, not by OS arch. The differences here are probably not win64-specific but something about the graphics hardware/driver of these hardware machines. And since this one is already fuzzy-if for Windows, I'd propose we just bump the fuzziness up. It's not clear to me what the new fuzziness values should be. dholbert how can you/I tell what maxDiff/diffCount should be given the two images in the log?
They're just the numbers quoted in comment 1. (max difference, number of differing pixels)
Attachment #8444209 - Flags: review?(dholbert)
Comment on attachment 8444209 [details] [diff] [review] Increase fuzziness Looks good!
Attachment #8444209 - Flags: review?(dholbert) → review+
Assignee: nobody → dmajor
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.