Remove unnecessary #includes of nsFrameManager.h

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla33
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In bug 1024084, I noticed that lots of things #include nsFrameManager.h without actually using it.

I filtered for files that #include nsFrameManager without actually using it by doing an MXR search for "FrameManager"...
http://mxr.mozilla.org/mozilla-central/search?string=FrameManager
...and looking for files with exactly one hit -- for just the #include.  (This easily screens out files that have e.g.
 presShell->FrameManager()->GetRootFrame()
which won't compile if it doesn't see the nsFrameManager definition.)

Upcoming patch removes the #include from the 10 .cpp files that I found w/ this technique. I verified that it builds locally w/ disable-unified-compilation, which I think means it's good.
(Assignee)

Comment 1

5 years ago
Created attachment 8438974 [details] [diff] [review]
fix v1
Attachment #8438974 - Flags: review?(jwatt)
(Assignee)

Comment 2

5 years ago
Created attachment 8438977 [details] [diff] [review]
fix v2

(er, now with the actual patch contents)
Assignee: nobody → dholbert
Attachment #8438974 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8438974 - Flags: review?(jwatt)
Attachment #8438977 - Flags: review?(jwatt)
(Assignee)

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 8438977 [details] [diff] [review]
fix v2

(thought I'd r+'ed this already)
Attachment #8438977 - Flags: review?(jwatt) → review+
https://hg.mozilla.org/mozilla-central/rev/b4224a22edac
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.