execute jshint for build directory

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: yurenju, Assigned: rickychien)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

we should execute jshint for build directory since we put a lot of js files there.
solving all of jshint related bugs should do those things:

1. remove certain js file in .jshintignore (for example build/webapp-optimize.js)
2. execute |jshint build/JS_FILE|
3. fix all jshint error/warning
4. send a pull request and check the result on tbpl (tbpl bot will automatically comment on your pull request)

please needinfo? me if you have any question.
There are so many joshing errors in current build/test/ and not only build/testintegration/build.test.js.
So I prefer to fix all of them once in this bug and close bug 1032030 since it seems to be no progress recently.
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED
Duplicate of this bug: 1032030
Created attachment 8541424 [details] [review]
Gaia PR
Attachment #8541424 - Flags: review?(gduan)
Attachment #8541424 - Attachment description: Gaia PR WIP → Gaia PR
Comment on attachment 8541424 [details] [review]
Gaia PR

good job! r=gduan
Attachment #8541424 - Flags: review?(gduan) → review+
Thanks. Let's merge it.

https://github.com/mozilla-b2g/gaia/commit/05211357a49df83310bd3901d6bbb25ac5e2c41e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.