Closed Bug 1024395 Opened 7 years ago Closed 7 years ago

Lockscreen color overlay not working due to bug 973443

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S4 (20june)

People

(Reporter: mnjul, Assigned: mnjul)

Details

(Whiteboard: [p=2])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
After landing of bug 973443, the lockscreen color overlay (as specified in bug 950884) no longer works.

This is because some of the changes in bug 950884's patch, involving wallpaper setting, was not carried over: https://github.com/mozilla-b2g/gaia/pull/19712/files#diff-2d905c358a85a6843f485bd807511752R42

I'll try fixing it.
Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur & George,

Please see if you have any questions/issues/comments regarding my patch. Thanks.
Attachment #8439089 - Flags: review?(arthur.chen)
Attachment #8439089 - Flags: feedback?(gduan)
Comment on attachment 8439089 [details] [review]
Github PR

Thanks for the patch, John! Please check my comment in github and add related unit tests protecting your work.
Attachment #8439089 - Flags: review?(arthur.chen)
Comment on attachment 8439089 [details] [review]
Github PR

nice.
My suggestions are the same as Arthur.
Attachment #8439089 - Flags: feedback?(gduan)
Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur,

The patch was revised according to your and george's comments.

Please review the patch again for me as bug 973443 got relanded. Many thanks!
Attachment #8439089 - Flags: review?(arthur.chen)
Comment on attachment 8439089 [details] [review]
Github PR

The patch looks good to me but there are a few nits to be addressed before merging. Please check my comments in github, thanks!
Attachment #8439089 - Flags: review?(arthur.chen)
Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur,

The patch was again revised to address the nits. Thanks for reviewing!
Attachment #8439089 - Flags: review?(arthur.chen)
Comment on attachment 8439089 [details] [review]
Github PR

r=me, thank you!
Attachment #8439089 - Flags: review?(arthur.chen) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/e67a8e42f734bb7dd425c58e1a1425153545fe72
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.