1024395 - Lockscreen color overlay not working due to bug 973443

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

After landing of bug 973443, the lockscreen color overlay (as specified in bug 950884) no longer works.

This is because some of the changes in bug 950884's patch, involving wallpaper setting, was not carried over: https://github.com/mozilla-b2g/gaia/pull/19712/files#diff-2d905c358a85a6843f485bd807511752R42

I'll try fixing it.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Github PR

Patch to replicate the efforts of https://github.com/mozilla-b2g/gaia/pull/19712/files#diff-39d8fcc7bf1d607a5a5b99794f1d7b69 ...

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur & George,

Please see if you have any questions/issues/comments regarding my patch. Thanks.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8439089 [details] [review]
Github PR

Thanks for the patch, John! Please check my comment in github and add related unit tests protecting your work.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8439089 [details] [review]
Github PR

nice.
My suggestions are the same as Arthur.

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur,

The patch was revised according to your and george's comments.

Please review the patch again for me as bug 973443 got relanded. Many thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8439089 [details] [review]
Github PR

The patch looks good to me but there are a few nits to be addressed before merging. Please check my comments in github, thanks!

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8439089 [details] [review]
Github PR

Hi Arthur,

The patch was again revised to address the nits. Thanks for reviewing!

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8439089 [details] [review]
Github PR

r=me, thank you!

Comment 9

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/e67a8e42f734bb7dd425c58e1a1425153545fe72