1024450 - expose preference to enable reviewer certificates

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Andrew Williamson [:eviljeff]]

Attachment: pull

bug 989806 (and others) added marketplace reviewer certficates to Gecko but enabling the necessary preference on Firefox devices still requires using adb with a rooted device to modify pref.js.  We'd like to reduce this significant hurdle adding a setting to the developer menu to toggle the pref.

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 8439152 [details] [review]
pull

That will only toggle a settings, but not the gecko pref. You need also to bind them on the gecko side (in b2g/chrome/content/settings.js)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

eviljeff: see http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#71 for an example of a binding between a Gaia setting and a Gecko pref.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #2)
> eviljeff: see
> http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.
> js#71 for an example of a binding between a Gaia setting and a Gecko pref.

Erm, for posterity, the permalink to this is:

  http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js?rev=78c20dbe259e#71

Comment 4

[Andrew Williamson [:eviljeff]]

Attachment: patch to add listener for settings change

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 8442503 [details] [diff] [review]
patch to add listener for settings change

Review of attachment 8442503 [details] [diff] [review]:
-----------------------------------------------------------------

Please re-request review on the gaia part to Evelyn

Comment 6

[Evelyn Hung]

Comment on attachment 8439152 [details] [review]
pull

looks good, thanks.

Comment 7

[Andrew Williamson [:eviljeff]]

This will go in 2.1 I assume - is there anything else to do before marking the bug as closed?

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Andrew Williamson [:eviljeff] from comment #7)
> This will go in 2.1 I assume - is there anything else to do before marking
> the bug as closed?

Landing the patches...

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2541c9bafc0d
Master: https://github.com/mozilla-b2g/gaia/commit/3778df9820535e75969f15dec2422cd894f774b4

The bug will be automatically resolved once this is merged from b2g-inbound to mozilla-central. There is nothing more you need to do here. One request, please ensure that your patches include a useful commit message in the future. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2541c9bafc0d