Closed Bug 1024450 Opened 7 years ago Closed 7 years ago

expose preference to enable reviewer certificates

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S5 (4july)

People

(Reporter: eviljeff, Assigned: eviljeff)

Details

Attachments

(2 files)

Attached file pull
bug 989806 (and others) added marketplace reviewer certficates to Gecko but enabling the necessary preference on Firefox devices still requires using adb with a rooted device to modify pref.js.  We'd like to reduce this significant hurdle adding a setting to the developer menu to toggle the pref.
Attachment #8439152 - Flags: review?(ehung)
Comment on attachment 8439152 [details] [review]
pull

That will only toggle a settings, but not the gecko pref. You need also to bind them on the gecko side (in b2g/chrome/content/settings.js)
Attachment #8439152 - Flags: review?(ehung) → review-
eviljeff: see http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#71 for an example of a binding between a Gaia setting and a Gecko pref.
(In reply to Myk Melez [:myk] [@mykmelez] from comment #2)
> eviljeff: see
> http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.
> js#71 for an example of a binding between a Gaia setting and a Gecko pref.

Erm, for posterity, the permalink to this is:

  http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js?rev=78c20dbe259e#71
Comment on attachment 8442503 [details] [diff] [review]
patch to add listener for settings change

Review of attachment 8442503 [details] [diff] [review]:
-----------------------------------------------------------------

Please re-request review on the gaia part to Evelyn
Attachment #8442503 - Flags: review?(fabrice) → review+
Attachment #8439152 - Flags: review- → review?(ehung)
Comment on attachment 8439152 [details] [review]
pull

looks good, thanks.
Attachment #8439152 - Flags: review?(ehung) → review+
This will go in 2.1 I assume - is there anything else to do before marking the bug as closed?
(In reply to Andrew Williamson [:eviljeff] from comment #7)
> This will go in 2.1 I assume - is there anything else to do before marking
> the bug as closed?

Landing the patches...
Keywords: checkin-needed
https://hg.mozilla.org/integration/b2g-inbound/rev/2541c9bafc0d
Master: https://github.com/mozilla-b2g/gaia/commit/3778df9820535e75969f15dec2422cd894f774b4

The bug will be automatically resolved once this is merged from b2g-inbound to mozilla-central. There is nothing more you need to do here. One request, please ensure that your patches include a useful commit message in the future. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Assignee: nobody → awilliamson
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2541c9bafc0d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.