1024495 - crash in mozilla::net::CacheFileIOManager::GetProfilelessCacheDirectory(nsIFile**)

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-ecb76a23-8178-424a-a50b-1b8cf2140610.
=============================================================

Comment 1

[Honza Bambas (:mayhemer)]

A bit strange crash (should not be null), but there is a code path we can get to this state - when the profile initiation fails somewhere...

Null check will do here, we are OK later (I will double check) when this is null.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

Re-checked we are OK to return null from here.

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8439309 [details] [diff] [review]
v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 961024
User impact if declined: null deref crash
Testing completed (on m-c, etc.): not even reviewed, soon will land
Risk to taking this patch (and alternatives if risky): zero
String or IDL/UUID changes made by this patch: none

Comment 4

[Honza Bambas (:mayhemer)]

https://tbpl.mozilla.org/?tree=Try&rev=26e093f8d2f1 (andr)
https://tbpl.mozilla.org/?tree=Try&rev=330f96a05bc3 (b2g, since I think ANDROID_WIDGET is defined there as well)

Comment 5

[Honza Bambas (:mayhemer)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be3d8910e738

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be3d8910e738

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Honza - This has now been on m-c for 4 days. Can you comment on the testing that has been conducted on Nightly? Any related bugs come in?

Comment 8

[Honza Bambas (:mayhemer)]

(In reply to Lawrence Mandel [:lmandel] from comment #7)
> Honza - This has now been on m-c for 4 days. Can you comment on the testing
> that has been conducted on Nightly? Any related bugs come in?

Actually, I was not even testing this locally since this is a very straightforward patch (see comment 1.)

No testing and to my knowledge no bugs either.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8439309 [details] [diff] [review]
v1

Gotcha. I should have looked at the patch. Approved for Aurora.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e13a7d705f6c