Closed Bug 1024592 Opened 10 years ago Closed 10 years ago

[spartacus] Check error view buttons make sense for the current error.

Categories

(Marketplace Graveyard :: Payments/Refunds, defect)

Product:
Marketplace Graveyard
Component:
Payments/Refunds
Version:
Avenir
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: scolville, Assigned: scolville)

References

Details

(Whiteboard: [qa-]) 

Some errors there's no retry needed and we only need a single button to cancel the flow.

There are in some cases an OK button and this isn't hooked up.

This bug is to clean that up and add tests to cover the errors so we check for the right number of buttons.

One way to do this would be to probably make the default for showCTA be false as that would then match the default events. 

That way if you need both a secondary button (e.g. cancel) and a primary call to action that can be explicit for only those cases.
Assignee: nobody → scolville
Status: NEW → ASSIGNED
https://github.com/mozilla/spartacus/commit/9d9738c31a4aec2125d485426cd5a3188dd0e605
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.