Closed Bug 1024600 Opened 10 years ago Closed 10 years ago

Enable test-attachment-reminder.js mozmill tests on Windows again

Categories

(Thunderbird :: Message Compose Window, defect)

All
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

We should try to enable test-attachment-reminder.js on Windows again. The tests were disabled in the past due to random timeouts on this platform. But since then new tests were added there and not disabled. And it seems there were no failures on Windows for them. Let's try to enable also the older tests again.
Attached patch patchSplinter Review
Aryx, could you please push to try server? Windows platform and mozmill tests only. Thanks.
Flags: needinfo?(archaeopteryx)
Thanks. Looks good. Can you somehow retry the tests so we can see if the success isn't intermittent?
Flags: needinfo?(archaeopteryx)
I have requested 2 reruns per Mozmill build.
Flags: needinfo?(archaeopteryx)
Comment on attachment 8439339 [details] [diff] [review]
patch

Thanks, looks to be working.
Attachment #8439339 - Flags: review?(mkmelin+mozilla)
Attachment #8439339 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/00bf8e77de73
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.