Closed Bug 1024615 Opened 10 years ago Closed 10 years ago

improper handling of INSTALL_FROM_DENIED error during desktop packaged app install

Categories

(Firefox Graveyard :: Web Apps, defect)

30 Branch
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1021234

People

(Reporter: bwalker, Unassigned)

Details

steps to reproduce: 1. visit a web page at host X that invokes mozApps.installPackaged() for a manifest whose installs_allowed_from field does not include X expected: * the onerror callback for installPackaged() will be called with INSTALL_FROM_DENIED (as happens for hosted apps) actual: * the onsuccess callback for installPackaged() is called, but the app does not install. -------- from console output: -*- Webapps.jsm : at install package got app etag="e5a29c23a417a562fe9bf8c3d586836be00f93ab2db84ad436a4cbd7861bcef1" --DOMWINDOW == 17 (0x122c11800) [pid = 46432] [serial = 12] [outer = 0x0] [url = about:home] -*- Webapps.jsm : confirmInstall -*- Webapps.jsm : _writeManifestFile -*- Webapps.jsm : Saving /Users/walker/Library/Application Support/Firefox/Profiles/pmef8uej.addondev/webapps/{c8c25eb1-0aa2-6046-86e8-02e58df469b6}/update.webapp -*- Webapps.jsm : app.origin: app://{c8c25eb1-0aa2-6046-86e8-02e58df469b6} -*- Webapps.jsm : Saving /Users/walker/Library/Application Support/Firefox/Profiles/pmef8uej.addondev/webapps/webapps.json -*- Webapps.jsm : No deviceStorage -*- Webapps.jsm : Free storage: 37745086464. Download size: 3265992 -*- Webapps.jsm : About to download https://marketplace.firefox.com/downloads/file/231637/here-maps-packaged-2.0.0.zip -*- Webapps.jsm : onProgress: 21825/3265992 -*- Webapps.jsm : Saving /Users/walker/Library/Application Support/Firefox/Profiles/pmef8uej.addondev/webapps/webapps.json [46432] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/slave/m-cen-osx64-d-0000000000000000/build/netwerk/base/src/nsFileStreams.cpp, line 203 [46432] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/slave/m-cen-osx64-d-0000000000000000/build/netwerk/base/src/nsFileStreams.cpp, line 475 -*- Webapps.jsm : onProgress: 2344685/3265992 -*- Webapps.jsm : Saving /Users/walker/Library/Application Support/Firefox/Profiles/pmef8uej.addondev/webapps/webapps.json -*- Webapps.jsm : File hash computed: 08a6e5c9aff9036de6835ad8b1b7b4ce -*- Webapps.jsm : package open/read error: INSTALL_FROM_DENIED -*- Webapps.jsm : Cleanup: INSTALL_FROM_DENIED undefined
Is this a duplicate of bug 1021234?
(In reply to Marco Castelluccio [:marco] from comment #1) > Is this a duplicate of bug 1021234? Yep! You'd think I would have remembered filing this already :-) I now see that in the other bug you wrote: "The update manifest doesn't specify installs_allowed_from, so the |onsuccess| callback of |installPackage| is successfully called. Then, when the package is downloaded, the |ondownloaderror| callback of the app object is called with INSTALL_FROM_DENIED." I need to add another callback for download errors, I hadn't realized that.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.