1024623 - [Vertical] Add collections to customization of vertical homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Marcelino Veiga Tuimil [:sonmarce]]

Follow up of bug 1006172 for adding collections to customization of vertical homescreen

Comment 1

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8440354 [details]
V1 Proposed patch

I did not test this, but I assume you tested it. I left a few nits on github.

One thing I'm not very clear on - what pieces are there to hook this up to the collections app? Is there some IAC message we need to send?

Comment 3

[Carmen Jimenez Cabezas]

Collection app listens for a 'setup' msg before populating the collection database with the predefined collections. 
I believe bug 1020158 was filed to implement that (send msg). 
If nobody from e.me takes it, I'll take it myself. In fact, I have a version of that implemented already since I needed data on the collection database to test the collection customization and launching the setup process was the easiest way to fill the database since the rest of the code (in collection app) was already in place

Comment 4

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/dfc4703bb81d1fa4f2087a1a6124b47a80a5d1de

Comment 5

[Carmen Jimenez Cabezas]

Comment on attachment 8440354 [details]
V1 Proposed patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Implementation of the vertical homescreen
[User impact] if declined: Collections on the homescreen will not be placed on the correct place according to the configuration file. This will difficult (or make impossible) to pass the certification process (since that's a requisite).
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/97c21d64d47c4c27d332841173c61f273c46f0d4

Comment 7

[sarsenyev]

Attachment: IssueOn2.0

Verified the issue is fixed on 2.2, 2.1
Customization of collection that is placed to the home vertical screen

Device: Flame 2.2 Master
BuildID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
BuildID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 8

[sarsenyev]

This issue still reproduces on Flame 2.0.

A new added collection is placed below divider of smart collection and placed to the another collection

Leaving verifyme keyword for 2.0 verification.

Flame 2.0 KK 

Flame 2.0Device: 
BuildID: 20141027000202
Gaia: 2183b4f3ec0eb47ab1f133c31732ec53b08ad253
Gecko: 43bee45176c4
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 9

[sarsenyev]

Follow-up bug is opened bug 1083297 as result of failed verification on 2.0