1024695 - Intermittent keyboard_settings_test.js | manipulate keyboard settings Launch built-in keyboard's settings page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jonathan Griffin (:jgriffin)]

07:26:04     INFO -  TEST-START | manipulate keyboard settings Launch built-in keyboard's settings page
07:26:44     INFO -  TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/settings/test/marionette/tests/keyboard_settings_test.js | manipulate keyboard settings Launch built-in keyboard's settings page
07:26:44     INFO -  TEST-END | manipulate keyboard settings Launch built-in keyboard's settings page

https://tbpl.mozilla.org/php/getParsedLog.php?id=41602654&tree=B2g-Inbound&full=1#error0

Comment 1

[Jonathan Griffin (:jgriffin)]

This is the newest frequent intermittent which prevents us from unhiding gaia-integration.

Comment 2

[Dylan Oliver [:doliver]]

Rudy, can you take a look and see if you can either fix or hide this test? We are close to getting the Gi tests visible on TBPL again but this intermittent is blocking us.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Sure, and sorry for that.
We have done stability check for that test, which means the test is stable on Travis.
I'll try to make it stable on TBPL as well or disable it if I cannnot make it in a timely manner.

Thanks for the heads-up.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

WIP here, to add waiting logic before switching to keyboard settings page, since I suspect the root cause of this intermittent failure is because we click the back button on the keyboard settings before the page is ready.

Will check the stability on travis first, since I have no idea how to run this test many times on TBPL.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Trying to run this test several times on Gaia Try with manual retriggering the "Gi" jobs.
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=fb800e167e3c3ef68a55417820400806b3cf7154

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8440553 [details] [review]
Patch V1

Gaia-Try has passed 10 times.
(Note: some "Gi" tests are still red, but none of them is caused by this failure).

Arthur, could you please review this change to improve the stability of this test?
Please let me know if we need to ask for Evan's help since he has done similar work in marionette-apps plugin for switchToApp() behavior.

Thanks.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8440553 [details] [review]
Patch V1

Evan, could you please help review this one since Arthur's review queue is quite long?

Thanks.

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8440553 [details] [review]
Patch V1

Hi Rudy,

Nice work.
Just a nit[1] for the patch. We should add a comment for the workaround.
Thanks.

[1] https://github.com/mozilla-b2g/gaia/pull/20548/files#diff-42a17e866f0c5427beed15ffe9cb998fR37

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8440553 [details] [review]
Patch V1

Evan, thanks for the review.
Patch updated to add the comment you mentioned.

Will land it after the travis CI is green.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/7b4665c7521a50e52b2053445d2a93c42a1f4ebd

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Uplifted to v2.0,
https://github.com/mozilla-b2g/gaia/commit/e91a2f634bb3b0c43b83afdc08d2c792cd94da97

--
The travis result: 
https://travis-ci.org/mozilla-b2g/gaia/builds/28491722
(The failed Gaia UI test should be irrelevant.)
Gaia-Try is green, https://tbpl.mozilla.org/?tree=Gaia-Try&rev=4df88fac58fce1db76232e8d08442618cc0c8ef2

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Jonathan,

Is there any easy way to take a look at these hidden builder job on aurora?
I'd like to help on monitoring the status for this test.

Thank you.

Comment 13

[Jonathan Griffin (:jgriffin)]

(In reply to Rudy Lu [:rudyl] from comment #12)
> Hi Jonathan,
> 
> Is there any easy way to take a look at these hidden builder job on aurora?
> I'd like to help on monitoring the status for this test.
> 
> Thank you.

Yes, you can use:  https://tbpl.mozilla.org/?tree=Mozilla-Aurora&showall=1&jobname=gaia-integration

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Jonathan, thanks a lot!