All users were logged out of Bugzilla on October 13th, 2018

PJS: Scheduler crash with large number of threads

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Using --thread-count=512 results in the following for me.

Assertion failure: state_ != TERMINATED, at /home/shu/moz/central/js/src/vm/ThreadPool.cpp:250
(Assignee)

Comment 1

4 years ago
Created attachment 8439516 [details] [diff] [review]
Don't set PJS helper thread state to TERMINATED on error when starting the helper threads.
Attachment #8439516 - Flags: review?(nmatsakis)
(Assignee)

Updated

4 years ago
Assignee: nobody → shu
Status: NEW → ASSIGNED
Attachment #8439516 - Flags: review?(nmatsakis) → review+

Comment 3

4 years ago
appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on machine11

from AWFY: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654
(Assignee)

Comment 4

4 years ago
(In reply to mayankleoboy1 from comment #3)
> appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on
> machine11
> 
> from AWFY:
> http://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654

I find that very hard to believe...
https://hg.mozilla.org/mozilla-central/rev/1a0c03f22654
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

Comment 6

4 years ago
(In reply to Shu-yu Guo [:shu] from comment #4)
> (In reply to mayankleoboy1 from comment #3)
> > appears to have caused a 7.4% regression on AWFY on  Octane-deltablue on
> > machine11
> > 
> > from AWFY:
> > http://hg.mozilla.org/integration/mozilla-inbound/
> > pushloghtml?fromchange=e024afb9f1d9&tochange=1a0c03f22654
> 
> I find that very hard to believe...

Thats what AWFY says.
The deltablue benchmark on machine 11 shows a regression from 31743 to 29403
You need to log in before you can comment on or make changes to this bug.