1024773 - amo-validator in-between push on or around June 17th

Status: RESOLVED FIXED

(Cloud Services :: Operations: Marketplace, task)

Description

[Andreas Wagner [:TheOne] [use NI]]

In order to run AMO Thunderbird compatibility tests in time before the release of next stable (31) in July, we need an in-between push of the amo-validator on or around June 17th.

The compatibility tests for Tb25-30 have already been landed with this month's push. However, the test for Tb31 could not land in time as 31 has just been uplifted to beta.

The patch that makes this in-between push necessary does not exist yet, however it should be done and ready for review on Monday (16th).

I will update this bug as soon as the patch has landed.

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

So, the patch in question has landen. It is https://github.com/mozilla/amo-validator/commit/99e26b99009d846d2f51db2805b3384bff35da7d

olympia has already been updated, see https://github.com/mozilla/olympia/commit/b9eb0ec57d2fc811ab97bcf8caf0145e956f3eef

Imho, we're good to push.

Comment 2

[Wil Clouser [:clouserw]]

Jason, Krupa - r?

Comment 3

[krupa raj[:krupa]]

Have the changes been QA'ed?

Comment 4

[Jason Thomas [:jason]]

I am okay with pushing as soon as it is QA r+

Comment 5

[Andreas Wagner [:TheOne] [use NI]]

Andrei or Mark could you please review this on -dev asap?

Comment 6

[Andrei Hajdukewycz [:sancus]]

I don't really know the QA process for the validator. In the past, we've passed on targeted QA for the Thunderbird validation tests because unit tests were sufficient, and I don't know what you guys do for normal "is it working?" QA.

Do we need to upload specific testing add-ons to ensure that the validator doesn't work? Bulk Validation doesn't appear to work properly on dev at all and it certainly hasn't been run on there in months, so that doesn't seem to be the correct way to do it.

Comment 7

[Wil Clouser [:clouserw]]

Krupa has test add-ons she works with.  Krupa - would you test the validator so we can push this today?  It sounds like you don't need to test this specific code, just that the rest of the validator still works.

Comment 8

[krupa raj[:krupa]]

I'm hitting a 500 on dev  during add-on validation.

GET https://addons-dev.allizom.org/en-US/developers/upload/24fa5c7cba154a5c8044f6139039d9b8/json [HTTP/1.1 500 Internal Server Error 31359ms]
09:54:35.314

Comment 9

[krupa raj[:krupa]]

Attachment: test add-on

Comment 10

[Andreas Wagner [:TheOne] [use NI]]

(In reply to krupa raj[:krupa] from comment #8)
> I'm hitting a 500 on dev  during add-on validation.
> 
> GET
> https://addons-dev.allizom.org/en-US/developers/upload/
> 24fa5c7cba154a5c8044f6139039d9b8/json [HTTP/1.1 500 Internal Server Error
> 31359ms]
> 09:54:35.314

That works just fine for me. Krupa, can you test again, please?

Comment 11

[krupa raj[:krupa]]

(In reply to Andreas Wagner [:TheOne] from comment #10)
> (In reply to krupa raj[:krupa] from comment #8)
> > I'm hitting a 500 on dev  during add-on validation.
> > 
> > GET
> > https://addons-dev.allizom.org/en-US/developers/upload/
> > 24fa5c7cba154a5c8044f6139039d9b8/json [HTTP/1.1 500 Internal Server Error
> > 31359ms]
> > 09:54:35.314
> 
> That works just fine for me. Krupa, can you test again, please?

Yes, works for me too. Weird.

Validation looks good. Let's push.

Comment 12

[Jason Thomas [:jason]]

Done.

https://dreadnot-prod.mktadm.ops.services.phx1.mozilla.com/stacks/addons.mozilla.org-olympia/regions/phx1/deployments/8