1024791 - Scan the add-on for tests instead of using require('@test/options').allTestModules

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment cfx/python feeds a list of filenames for tests through require('@test/options').allTestModules.  Instead of this we should scan the add-on for test files so that a tool like jpm doesn't have to input them.

Long term we want to use a "test" key in the package.json file, which would point to a js file that could run any desired test suite, at the moment our default one will be used, which currently takes a list of test files via require('@test/options').allTestModules and I would like to change to have it scan for the test files automatically.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

ie default affected is `{ "test": "sdk/test/runner" }`

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1511

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8439635 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1511

I like it overall, although would much rather leveraged all util/sequence stuff to make improve expressiveness & add laziness. That being said I leave it up to you, as I don't think either is important enough to block this.

I also r+ it as end up doing full review anyhow. I would just recommend making sure that we run same amount of tests with and without this change.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1527be422f20e51739f4ffceb28d1f7ffd7eed3b
Bug 1024791 - Scan the add-on for tests

https://github.com/mozilla/addon-sdk/commit/a9750f0778cde2e811e5a298fbf46e5eda107154
Merge pull request #1511 from erikvold/1024791

Bug 1024791 - Scan the add-on for tests r=@gozala

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d79e4ea09a8062b4033527270e69dc85a03a200c
Bug 1024791 bug fix when using --filter a=me

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1521

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8443241 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1521

Awesome stuff -- just a comment on the PR that could remove code dupe, and possibly an off-by-one error

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ea76904f93a2a131d6b02f2d11b0b3ca65e3e9ce
Bug 1024791 - Scan the add-on for tests

https://github.com/mozilla/addon-sdk/commit/1059f2cd08b9f0fe7d7a14e776085750e73d556e
Bug 1024791 removing duplicate logic

https://github.com/mozilla/addon-sdk/commit/f6bc93143d72c8a498099b39d8ddaf98a2071f52
Merge pull request #1521 from erikvold/1024791

Bug 1024791 - Scan the add-on for tests r=@jsantell