Use _HAS_EXCEPTIONS=0 when building the JS engine on Windows

RESOLVED FIXED in mozilla33

Status

Firefox Build System
General
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8439652 [details] [diff] [review]
Use _HAS_EXCEPTIONS=0 when building the JS engine on Windows
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 752004
(Assignee)

Updated

4 years ago
Attachment #8439652 - Flags: review?(mh+mozilla)
Comment on attachment 8439652 [details] [diff] [review]
Use _HAS_EXCEPTIONS=0 when building the JS engine on Windows

Review of attachment 8439652 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +516,5 @@
>      if test "$GCC" != "yes" -o -n "$CLANG_CC" ; then
>          MOZ_FIND_WINSDK_VERSION
>      fi
>  
> +    CFLAGS="$CFLAGS -D_HAS_EXCEPTIONS=0"

Should probably avoid this with gcc.
Attachment #8439652 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/193ef9b92584
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.