[System] Use shared uuid.js

RESOLVED FIXED in 2.0 S4 (20june)

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.0 S4 (20june)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1],[systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1022976 we decided to move uuid into shared/ for use across apps. The system app uses the same file, so to reduce confusion let's move it.
(Assignee)

Updated

3 years ago
Whiteboard: [p=1],[systemsfe]
(Assignee)

Comment 1

3 years ago
Created attachment 8439712 [details] [review]
Github pull request
(Assignee)

Comment 2

3 years ago
Comment on attachment 8439712 [details] [review]
Github pull request

A fairly simple change to use the shared uuid.js which we landed for the vertical homescreen. (Calendar also uses this library)
Attachment #8439712 - Flags: review?(timdream)
Attachment #8439712 - Flags: review?(alive)
Comment on attachment 8439712 [details] [review]
Github pull request

Not sure if it's possible but do we have unit test for in this script?
Attachment #8439712 - Flags: review?(timdream)
Attachment #8439712 - Flags: review?(alive)
Attachment #8439712 - Flags: review+
(Assignee)

Comment 4

3 years ago
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> Comment on attachment 8439712 [details] [review]
> Github pull request
> 
> Not sure if it's possible but do we have unit test for in this script?

It's an external script, and it seems pretty hard, but we may be able to create some. I do know we have several unit tests and marionette tests that rely on this script, and would fail if it breaks in some cases.


Landed: https://github.com/mozilla-b2g/gaia/commit/1396f543d02bb2908a9243451bd6ee6fb4a08b8b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S4 (20june)
You need to log in before you can comment on or make changes to this bug.