Closed Bug 1024910 Opened 9 years ago Closed 9 years ago
Errors "A promise chain failed to handle a rejection" output in browser console when hovering over the rule-view
I don't have exact steps to reproduce and this issue seems rather random. It might even also occur on the computed-view, not sure. STR: - open the inspector on a page - open the browser console (cmd+shift+J) - move your mouse over the rule-view - wait, repeat ... Sometimes, not really as you move the mouse, but after a while, a series of "A promise chain failed to handle a rejection" errors will be output to the browser console. They tend to come in groups, sometimes 3 at the same time, sometimes a lot more. And, they tend to come completely asynchronously to any client-side action you might be doing in the rule-view. However, they don't seem to occur with other panels, or if the devtools are closed, so there is definitely a link with the rule-view. The full error is: "A promise chain failed to handle a rejection. Date: Fri Jun 13 2014 10:32:31 GMT+0200 (CEST) Full Message: false"
I saw similar errors when using Network Monitor and I tracked the problem down to Tooltip._onBaseNodeMouseMove which does not catch rejections .isValidHoverTarget throws. isValidHoverTarget rejects every time mouse moves over an element that should not trigger the tooltip. I think these are same problems as tooltips are used in the rule-view (and few other places) too. STR with Network Monitor: 1. Open network monitor and browser console. 3. Navigate to a page that performs a few requests. 4. Move mouse over netmonitor items and wait a while. 5. Bunch of errors should appear to browser console. Here's a try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d8278b773265  http://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#416
Attachment #8534920 - Flags: review?(pbrosset)
Comment on attachment 8534920 [details] [diff] [review] tooltip-uncaught-rejections.patch Review of attachment 8534920 [details] [diff] [review]: ----------------------------------------------------------------- Wow, good catch Sami! Thanks for fixing this, this has been really annoying for a long time. The code changes look good to me, and try is green, so let's land this.
Attachment #8534920 - Flags: review?(pbrosset) → review+
Sami, can you change the commit message to end with "; r=pbrosset" ? Thanks!
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Depends on: 1110486
You need to log in before you can comment on or make changes to this bug.