1024932 - addSwatch originalValue never passed in but used in function body

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR:
1. Search for addSwatch
2. You will see that the function declaration has originalValue after a default parameter (default params have to be last).

We never actually pass in originalValue but make use of it in this.swatches.set()

We should remove all references to originalValue from addSwatch and it should work fine.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: bug1024932-clean-up-addSwatch-tooltip v1.patch

Ongoing try build https://tbpl.mozilla.org/?tree=Try&rev=a486c4f4b4ba

Comment 2

[Patrick Brosset <:pbro>]

https://tbpl.mozilla.org/?tree=Try&rev=a486c4f4b4ba
https://hg.mozilla.org/integration/fx-team/rev/00681f1336d5

Comment 3

[Ed Morley [:emorley]]

Backed out for failures in for failures in test_bug455906.js on Windows opt:
https://tbpl.mozilla.org/php/getParsedLog.php?id=42268768&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=42268821&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=42269482&tree=Fx-Team

remote:   https://hg.mozilla.org/integration/fx-team/rev/39f91b682025

Comment 4

[Patrick Brosset <:pbro>]

Looking at the failures, I don't see how the patch could have caused this.
I updated my fx-team, re-applied my patch and started a few windows opt xpcshell tests: https://tbpl.mozilla.org/?tree=Try&rev=87c10ec17c77
The tests seem to be passing so far. I will wait until all retrigger pass and will re-land the patch.

Comment 5

[Patrick Brosset <:pbro>]

Re-landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/1fee2490350f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1fee2490350f