Closed
Bug 1024933
Opened 7 years ago
Closed 7 years ago
[Text Selection] Utility bubble's shadow improvement
Categories
(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S4 (20june)
People
(Reporter: Carol, Assigned: gduan)
References
Details
(Whiteboard: [p=2])
Attachments
(4 files)
44.94 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
alive
:
review+
|
Details | Review |
132.10 KB,
image/png
|
Carol
:
ui-review+
|
Details |
144.08 KB,
image/png
|
Carol
:
ui-review+
|
Details |
Utility bubble is too heavy right now.
Reporter | ||
Updated•7 years ago
|
Blocks: CopyPasteLegacy
Reporter | ||
Comment 1•7 years ago
|
||
Hi George, Text selection Visual spec revised: Please help adjust the utility menu's shadow. Shadow: 2px 2px 5px 3px #3d3d3d Let me know when you're done so I can see if the shadow looks good enough. Thank you!:)
Flags: needinfo?(gduan)
Reporter | ||
Comment 2•7 years ago
|
||
Hi George, Visual UI update the utility menu's shadow: 1px 1px 2px 1px #3d3d3d Thank you very much!
Assignee | ||
Comment 3•7 years ago
|
||
Hi Carol, I would like to remove the leftest border when we only have one paste option in this bug, what do you think?
Flags: needinfo?(gduan) → needinfo?(chuang)
Assignee | ||
Comment 4•7 years ago
|
||
Reporter | ||
Comment 5•7 years ago
|
||
Hey George, Yes, the divider only exist "between keys" but on the "sides". Please remove it when it's only one paste option. Thanks :-)
Flags: needinfo?(chuang)
Assignee | ||
Updated•7 years ago
|
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S4 (20june)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gduan
Assignee | ||
Comment 6•7 years ago
|
||
Please check the shadow and the existence of left border.
Attachment #8441824 -
Flags: ui-review?(chuang)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8441826 -
Flags: ui-review?(chuang)
Reporter | ||
Comment 8•7 years ago
|
||
Comment on attachment 8441826 [details]
left border
the border looks clean now! thanks, George!
Attachment #8441826 -
Flags: ui-review?(chuang) → ui-review+
Assignee | ||
Comment 9•7 years ago
|
||
Thanks Carol, In fact, the four corners are a little blurred, and it's a general issue in gaia. So, I open bug 1026892 to trace it.
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8440566 [details] [review] PR to master Hi Alive, could you take a look of this patch? Thanks.
Attachment #8440566 -
Flags: review?(alive)
Updated•7 years ago
|
Attachment #8440566 -
Flags: review?(alive) → review+
Assignee | ||
Comment 11•7 years ago
|
||
Thanks, tbpl pass. master: https://github.com/mozilla-b2g/gaia/commit/210754620ef706662c3379eb9fbb53c6e5b21baa
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•7 years ago
|
Attachment #8441824 -
Flags: ui-review?(chuang) → ui-review+
You need to log in
before you can comment on or make changes to this bug.
Description
•