[Text Selection] Utility bubble's shadow improvement

RESOLVED FIXED in 2.0 S4 (20june)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Carol, Assigned: gduan)

Tracking

unspecified
2.0 S4 (20june)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=2])

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
Created attachment 8439791 [details]
2014-05-30-06-21-14.png

Utility bubble is too heavy right now.
(Reporter)

Updated

5 years ago
Blocks: 1023688
(Reporter)

Comment 1

5 years ago
Hi George,
Text selection Visual spec revised: 
Please help adjust the utility menu's shadow.
Shadow: 2px 2px 5px 3px #3d3d3d
Let me know when you're done so I can see if the shadow looks good enough.

Thank you!:)
Flags: needinfo?(gduan)
(Reporter)

Comment 2

5 years ago
Hi George,
Visual UI update
the utility menu's shadow: 
1px 1px 2px 1px #3d3d3d

Thank you very much!
Hi Carol,
I would like to remove the leftest border when we only have one paste option in this bug, what do you think?
Flags: needinfo?(gduan) → needinfo?(chuang)
(Reporter)

Comment 5

5 years ago
Hey George,
Yes, the divider only exist "between keys" but on the "sides".
Please remove it when it's only one paste option. Thanks :-)
Flags: needinfo?(chuang)
Whiteboard: [p=2]
Target Milestone: --- → 2.0 S4 (20june)
Assignee: nobody → gduan
Created attachment 8441824 [details]
shadow and left border

Please check the shadow and the existence of left border.
Attachment #8441824 - Flags: ui-review?(chuang)
Created attachment 8441826 [details]
left border
Attachment #8441826 - Flags: ui-review?(chuang)
(Reporter)

Comment 8

5 years ago
Comment on attachment 8441826 [details]
left border

the border looks clean now! thanks, George!
Attachment #8441826 - Flags: ui-review?(chuang) → ui-review+
Thanks Carol,

In fact, the four corners are a little blurred, and it's a general issue in gaia. So, I open bug 1026892 to trace it.
Comment on attachment 8440566 [details] [review]
PR to master

Hi Alive,
could you take a look of this patch?
Thanks.
Attachment #8440566 - Flags: review?(alive)
Attachment #8440566 - Flags: review?(alive) → review+
Thanks,
tbpl pass.

master:
https://github.com/mozilla-b2g/gaia/commit/210754620ef706662c3379eb9fbb53c6e5b21baa
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Attachment #8441824 - Flags: ui-review?(chuang) → ui-review+
You need to log in before you can comment on or make changes to this bug.