1024950 - [1.4] There should not show "sending" dialog when dialing USSD code without sim card inside.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Wei Gao (Spreadtrum)]

OS version
---------------------------------------------
FireFoxOS v1.3t v1.4

Reproduce steps:
---------------------------------------------
Dial USSD code like "*...#" without sim card inside.

Actual result:
---------------------------------------------
show "sending" dialog 

Expected result:
---------------------------------------------
Should show emergency only dialog

Probability:
---------------------------------------------
Always Recurrence

Comment 1

[Wei Gao (Spreadtrum)]

Attachment: detect_sim_state_before_dialing_USSD.patch

Hi Etienne

This is a patch for this on v1.4,
It will show emergency only dialog when dialing USSD code without sim card inside
Can it be granted?

Please help to review.
Thanks.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8439848 [details] [diff] [review]
detect_sim_state_before_dialing_USSD.patch

mmi, redirecting to Rik

Comment 3

[Anthony Ricaud (:rik)]

Comment on attachment 8439848 [details] [diff] [review]
detect_sim_state_before_dialing_USSD.patch

Review of attachment 8439848 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for that patch. I'd like some context: You mention it's a patch for 1.4 but right now, even if I see the sending dialog, I see a "generic failure" screen after. Not the nicest error message but I don't think this is bad enough to justify a 1.4-only patch. Am I missing a detail?

This is duplicating the code that displays error messages. I'd rather not do that. Also, we'll get good error handling for free once bug 889737 lands.

Comment 4

[Wei Gao (Spreadtrum)]

(In reply to Anthony Ricaud (:rik) from comment #3)
> Comment on attachment 8439848 [details] [diff] [review]
> detect_sim_state_before_dialing_USSD.patch
> 
> Review of attachment 8439848 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for that patch. I'd like some context: You mention it's a patch for
> 1.4 but right now, even if I see the sending dialog, I see a "generic
> failure" screen after. Not the nicest error message but I don't think this
> is bad enough to justify a 1.4-only patch. Am I missing a detail?
> 
> This is duplicating the code that displays error messages. I'd rather not do
> that. Also, we'll get good error handling for free once bug 889737 lands.

Sorry, because there is no "generic failure" screen show, I check the code again and find that's a bug of dolphin(sprd7715). After execute "_conn.sendMMI(message)" without sim card inside, it return "onsuccess", so that should be resolved by our sprd.

Thanks.

Comment 5

[Anthony Ricaud (:rik)]

Cool ! Can we close this bug then? (and wait for bug 889737 to get the nicer UI)

Comment 6

[Wei Gao (Spreadtrum)]

(In reply to Anthony Ricaud (:rik) from comment #5)
> Cool ! Can we close this bug then? (and wait for bug 889737 to get the nicer
> UI)

Hi Anthony

Thanks for your attention.
Let's close it, and sorry to trouble you.
Bye the way, How can i close this bug?
Thanks.

Comment 7

[Anthony Ricaud (:rik)]

No problem.

To close a bug, change its status to RESOLVED. And then choose a resolution. This one was INVALID.

Comment 8

[Wei Gao (Spreadtrum)]

(In reply to Anthony Ricaud (:rik) from comment #7)
> No problem.
> 
> To close a bug, change its status to RESOLVED. And then choose a resolution.
> This one was INVALID.

Thank you very much.