Regalloc: Comment the difference between useRegister and useRegisterAtStart

RESOLVED FIXED in mozilla33

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla33
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8439899 [details] [diff] [review]
Comment the difference between use* and use*AtStart during Lowering

This is mainly formatting of what has been said in #ionmonkey today. Opinions?
Attachment #8439899 - Flags: review?(jdemooij)
Attachment #8439899 - Flags: feedback?(hv1989)
Comment on attachment 8439899 [details] [diff] [review]
Comment the difference between use* and use*AtStart during Lowering

Review of attachment 8439899 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/shared/Lowering-shared.h
@@ +96,4 @@
>      inline LAllocation useAny(MDefinition *mir);
>      inline LAllocation useAnyOrConstant(MDefinition *mir);
> +    // "Storable" is architecture dependend, and will include registers and
> +    // constants on X86 and only registers on ARM.  this is a generic "things

s/ this/This/
Attachment #8439899 - Flags: feedback?(hv1989) → feedback+
Comment on attachment 8439899 [details] [diff] [review]
Comment the difference between use* and use*AtStart during Lowering

Review of attachment 8439899 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! We should have added this a long time ago :)

::: js/src/jit/shared/Lowering-shared.h
@@ +69,5 @@
> +    //
> +    // Some of these use functions have atStart variants.
> +    // - non-atStart variants will tell the register allocator that the input
> +    // allocation is guaranteed to be different from any Temp or Definition
> +    // also needed for this LInstruction.

Nit: s/is guaranteed to be different/must be different

@@ +96,5 @@
>      inline LAllocation useAny(MDefinition *mir);
>      inline LAllocation useAnyOrConstant(MDefinition *mir);
> +    // "Storable" is architecture dependend, and will include registers and
> +    // constants on X86 and only registers on ARM.  this is a generic "things
> +    // we can expect to write into memory in 1 instruction"

Nit: add a period at the end.
Attachment #8439899 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/614ff409333c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.