1025033 - Dark theme scrollbars have white background on OSX with external mouse

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Nightly - Broken scrollbars.PNG

When using the dark theme the scrollbars are now from deep in the land of ugly on Nightly https://hg.mozilla.org/integration/fx-team/rev/d3d04ca08d9c (see Nightly attachment).

In Aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/2c3bd98786d7 they looked beautifully crafted, smooth and sexy (see Aurora attachment).

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Aurora - Working scrollbars.PNG

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Scrollbar behaviour.PNG

A quick note that this only happens when "Show scroll bars" is set to anything other than "When scrolling."

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #2)
> Created attachment 8439929 [details]
> Scrollbar behaviour.PNG
> 
> A quick note that this only happens when "Show scroll bars" is set to
> anything other than "When scrolling."

Actually, only when set to Always.

Comment 4

[Brian Grinstead [:bgrins]]

This seems to be reproducible only when a mouse is plugged in

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Was there a recent change in the way "Show scroll bars: Always" is interpreted by Gecko?

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Brian Grinstead [:bgrins] from comment #4)
> This seems to be reproducible only when a mouse is plugged in

And only with Mike's Logitech mouse. With Patrick's Apple mouse it works as before.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Stephen Pohl is away on vacation, and I don't know much about this code.

Since you can reproduce this problem, please find the regression range in mozilla-central nightlies.  That will likely shed more light on it.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Steven Michaud from comment #7)
> Stephen Pohl is away on vacation, and I don't know much about this code.
> 
> Since you can reproduce this problem, please find the regression range in
> mozilla-central nightlies.  That will likely shed more light on it.

Will do... from the regression range it seems like we landed a bunch of devtools UI changes at the same time that a bunch of scrollbar drawing changes were made on the platform side so we need to narrow to the actual changeset.

Still working on that.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Paul, I vaguely remember that you used some hack to get the floating scrollbars working, do you remember what we did?

Comment 10

[Paul Rouget [:paul]]

Might be related to the recent APZC work... not sure (bug 944938 and/or bug 814435).

What happens with the white theme?

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

White theme looks fine.

I am quickly narrowing it down to the APZC work but we both landed our changes really close together. Let's see what mozregression tells us.

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Bug 1016569 broke the dark theme scrollbars in our devtools:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81a4f16df918

Looking for a workaround.

Comment 13

[Stephen A Pohl [:spohl]]

Forwarding n-i request to mstange.

Comment 14

[Markus Stange [:mstange]]

Looking.

Comment 15

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Screen Shot 2014-06-17 at 11.28.47.PNG

Comment 17

[Dane MacMillan [:danemacmillan]]

Hi, Mike

I'm experiencing the same problem, as I duplicated in bug 1029103. I don't have an external mouse, but my OSX has been set to "Always" show the scrollbars. Unfortunately, there's not much more I can add to this discussion.

Comment 18

[Markus Stange [:mstange]]

Attachment: v1

The white is coming from the <slider> inside the scrollbar. Before bug 1016569 we were rendering the white scrollbar track background as part of the <scrollbar>'s -moz-appearance, and now it's part of the <slider>'s -moz-appearance. Devtools floating scrollbars set the scrollbar's -moz-appearance to none but leave the slider's. Setting the slider's -moz-appearance to none as well gets rid of the white parts. However, it also removes the slider's minimum size, so with only that change the slider would collapse and the scrollbar thumb wouldn't be visible. So I'm also removing the -moz-box-align property on the scrollbar so that it goes back to "stretch", which gives the slider and thumb elements the right size. I don't know why the -moz-box-align override was added originally, but I haven't noticed any problems with it removed.

Comment 19

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/fx-team/rev/b4fcdf70278f

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4fcdf70278f

Comment 21

[Lawrence Mandel [:lmandel] (use needinfo)]

This looks like a simple fix. Can you nom for Aurora so that we can uplift?

Comment 22

[Markus Stange [:mstange]]

Comment on attachment 8446506 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: regression from bug 1016569
[User impact if declined]: ugly devtools scrollbars on Mac
[Describe test coverage new/current, TBPL]: none
[Risks and why]: low risk, simple CSS change
[String/UUID change made/needed]: none

Comment 23

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8446506 [details] [diff] [review]
v1

Aurora+

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2861d0942a34