1025066 - Support ssl (i.e. https / wss) in web-platform-tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

This should be possible using the same approach that mochitest uses, which aiui is something like installing a fake ca into the temporary profile and using a certificate from that ca for the server processes.

Comment 1

[(not currently active) Ted Mielczarek]

It's *slightly* more involved than that, but that's the right basic premise.

You need the ssltunnel binary from a test package (the right one for your host system) and you need to write a configuration file for it like so:
http://hg.mozilla.org/mozilla-central/annotate/48eee276b1ee/testing/mochitest/runtests.py#l680

You also need the certs/ directory from a test package, that has the prebuilt certificate store with all the testing certs. Then you need to fill the certificate DB in your test profile like so:
http://hg.mozilla.org/mozilla-central/annotate/48eee276b1ee/testing/mochitest/runtests.py#l900

That code already has a comment saying it ought to move to mozprofile, so if you want to use it now might be a good time.

The "locations" stuff that all of this talks about is using this file, which is also in the test package:
http://mxr.mozilla.org/mozilla-central/source/build/pgo/server-locations.txt

Comment 2

[(not currently active) Ted Mielczarek]

Alternately if you wanted to just build your own certificate store, the script that does that is here:
http://mxr.mozilla.org/mozilla-central/source/build/pgo/genpgocert.py

Note that all of this requires some NSS commandline tools for the host system as well.

Comment 3

[James Graham [:jgraham]]

Code review at https://critic.hoppipolla.co.uk/r/3002

Comment 4

[James Graham [:jgraham]]

Attachment: Upstream changes

Comment 5

[James Graham [:jgraham]]

Attachment: Enable web-platform-tests script to access the certutils binary

mozharness changes

Comment 6

[James Graham [:jgraham]]

Attachment: MozReview Request: bz://1025066/jgraham

Comment 7

[James Graham [:jgraham]]

/r/1617 - Bug 1025066 - Add certs and mach integration for running web-platform-tests with https.

Pull down this commit:

hg pull review -r 0ae890e02b3b522e2a6e3c7d25e6fe636cfcde82

Comment 8

[Armen [:armenzg]]

Comment on attachment 8540072 [details] [diff] [review]
Enable web-platform-tests script to access the certutils binary

Review of attachment 8540072 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/web_platform_tests.py
@@ +138,5 @@
>  
>          str_format_values = {
>              'binary_path': self.binary_path,
>              'test_path': dirs["abs_wpttest_dir"],
> +            'test_install_path': dirs["abs_test_install_dir"],

What is this for?

Comment 9

[James Graham [:jgraham]]

(In reply to Armen Zambrano - Automation & Tools Engineer (:armenzg) from comment #8)
> Comment on attachment 8540072 [details] [diff] [review]
> Enable web-platform-tests script to access the certutils binary
> 
> Review of attachment 8540072 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: scripts/web_platform_tests.py
> @@ +138,5 @@
> >  
> >          str_format_values = {
> >              'binary_path': self.binary_path,
> >              'test_path': dirs["abs_wpttest_dir"],
> > +            'test_install_path': dirs["abs_test_install_dir"],
> 
> What is this for?

I need to get at the bin/ directory from the in-tree configs so that I can pass the location of the certutil binary to wptrunner (see the mozreview review on this bug).

Comment 10

[James Graham [:jgraham]]

https://tbpl.mozilla.org/?tree=Try&rev=4a3ab0af566a

Comment 11

[James Graham [:jgraham]]

https://tbpl.mozilla.org/?tree=Try&rev=9b29de231a57

Comment 12

[James Graham [:jgraham]]

https://tbpl.mozilla.org/?tree=Try&rev=fb3edfe54138

Comment 13

[(not currently active) Ted Mielczarek]

https://reviewboard.mozilla.org/r/1615/#review1275

::: testing/web-platform/mach_commands.py
(Diff revision 1)
> +                kwargs["host_cert_path"] = os.path.join(here, "certs", "web-platform.test.pem")

I definitely wish there was a nicer way to set these defaults on the options parser, and even to not expose these as commandline options at all for the mach command (since there's no reason to change the defaults when running on a local build), but your existing code that shares the commandline parser with the harness is better than most of our harnesses already so I don't have a great suggestion.

Comment 14

[James Graham [:jgraham]]

https://tbpl.mozilla.org/?tree=Try&rev=d75d1187d8c6

Comment 15

[James Graham [:jgraham]]

https://tbpl.mozilla.org/?tree=Try&rev=ec7c0632b156

Comment 16

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/mozharness/rev/3ae51b94a56a

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47671b5f66ab
https://hg.mozilla.org/mozilla-central/rev/d16c7eac45de
https://hg.mozilla.org/mozilla-central/rev/93c1be376911
https://hg.mozilla.org/mozilla-central/rev/5e38f65cb587

Comment 19

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1025066 - Add certs and mach integration for running web-platform-tests with https.