1025069 - Both Versions of SUMO (http & https - suggested) can be pinned

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Ioana Chiorean]

Attachment: Screenshot

S: Android 4.4 
Device: Nexus 4

Steps:
1. Tap to add a new site to Top sites Grid
2. Choose the SUMO page which is bookmark (http://support.mozilla.org/en-US/product/mobile)
3. Tap to edit this last added pin
4. Add https instead of http - make it https://support.mozilla.org/en-US/product/mobile

Expected Results:
- you should have only one SUMO in Top Sites Grid

Actual Result:
- you have 3 SUMO pins in Top Site Grid

Note:
- see attached screenshot
- Suggested site is : https://support.mozilla.org/en-US/product/mobile

Comment 1

[Ioana Chiorean]

I mean https://support.mozilla.org/en-US/products/mobile
* missing a s at products

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Use https URL on SUMO's default bookmark (r=mfinkle)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8441276 [details] [diff] [review]
Use https URL on SUMO's default bookmark (r=mfinkle)

This is happening because the URLs of the default bookmark and suggested site don't match. I updated the default bookmark to match the suggested site's URL (i.e. use https). This will fix the issue for new users but not for existing ones because the default bookmarks are added to the DB on first run only.

If we *really* want to fix this for existing users, we can write a DB migration just to update the default bookmark. Not worth it IMO.

Comment 4

[Ioana Chiorean]

Lucas, is this fixing the editing problem? 
As mentioned in description even if I was editing it to match in URLs it displayed a globe icon and not the suggested site (suggested site, bookmark - sumo favicon, editing it - globe favicon)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8441276 [details] [diff] [review]
Use https URL on SUMO's default bookmark (r=mfinkle)

We do not need to change the entity name here. The l10n is done in a different file, so we do not need to change _support -> _support2

r+, but revert the entity change

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Ioana Chiorean from comment #4)
> Lucas, is this fixing the editing problem? 
> As mentioned in description even if I was editing it to match in URLs it
> displayed a globe icon and not the suggested site (suggested site, bookmark
> - sumo favicon, editing it - globe favicon)

We need a couple fixes around user entered pinned sites and suggested sites. I filed bug 1035131 to track this.

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 8441276 [details] [diff] [review]
> Use https URL on SUMO's default bookmark (r=mfinkle)
> 
> We do not need to change the entity name here. The l10n is done in a
> different file, so we do not need to change _support -> _support2
> 
> r+, but revert the entity change

Done, pushed: https://hg.mozilla.org/integration/fx-team/rev/be0ae5640b90

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out since it caused https://tbpl.mozilla.org/php/getParsedLog.php?id=43244622&tree=Fx-Team

Comment 9

[Lucas Rocha (:lucasr)]

Oops, forgot to update StringHelper for robocop tests. Done, pushed:
https://hg.mozilla.org/integration/fx-team/rev/11bdc7637af1

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11bdc7637af1