Closed Bug 1025069 Opened 7 years ago Closed 7 years ago

Both Versions of SUMO (http & https - suggested) can be pinned

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox32 affected, firefox33 affected)

RESOLVED FIXED
Firefox 33
Tracking Status
firefox32 --- affected
firefox33 --- affected

People

(Reporter: ioana.chiorean, Assigned: lucasr)

References

Details

Attachments

(2 files)

Attached image Screenshot
S: Android 4.4 
Device: Nexus 4

Steps:
1. Tap to add a new site to Top sites Grid
2. Choose the SUMO page which is bookmark (http://support.mozilla.org/en-US/product/mobile)
3. Tap to edit this last added pin
4. Add https instead of http - make it https://support.mozilla.org/en-US/product/mobile

Expected Results:
- you should have only one SUMO in Top Sites Grid

Actual Result:
- you have 3 SUMO pins in Top Site Grid

Note:
- see attached screenshot
- Suggested site is : https://support.mozilla.org/en-US/product/mobile
I mean https://support.mozilla.org/en-US/products/mobile
* missing a s at products
Flags: needinfo?(lucasr.at.mozilla)
QA Contact: ioana.chiorean
Assignee: nobody → lucasr.at.mozilla
Flags: needinfo?(lucasr.at.mozilla)
Comment on attachment 8441276 [details] [diff] [review]
Use https URL on SUMO's default bookmark (r=mfinkle)

This is happening because the URLs of the default bookmark and suggested site don't match. I updated the default bookmark to match the suggested site's URL (i.e. use https). This will fix the issue for new users but not for existing ones because the default bookmarks are added to the DB on first run only.

If we *really* want to fix this for existing users, we can write a DB migration just to update the default bookmark. Not worth it IMO.
Attachment #8441276 - Flags: review?(mark.finkle)
Lucas, is this fixing the editing problem? 
As mentioned in description even if I was editing it to match in URLs it displayed a globe icon and not the suggested site (suggested site, bookmark - sumo favicon, editing it - globe favicon)
Comment on attachment 8441276 [details] [diff] [review]
Use https URL on SUMO's default bookmark (r=mfinkle)

We do not need to change the entity name here. The l10n is done in a different file, so we do not need to change _support -> _support2

r+, but revert the entity change
Attachment #8441276 - Flags: review?(mark.finkle) → review+
Blocks: 1035131
(In reply to Ioana Chiorean from comment #4)
> Lucas, is this fixing the editing problem? 
> As mentioned in description even if I was editing it to match in URLs it
> displayed a globe icon and not the suggested site (suggested site, bookmark
> - sumo favicon, editing it - globe favicon)

We need a couple fixes around user entered pinned sites and suggested sites. I filed bug 1035131 to track this.
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 8441276 [details] [diff] [review]
> Use https URL on SUMO's default bookmark (r=mfinkle)
> 
> We do not need to change the entity name here. The l10n is done in a
> different file, so we do not need to change _support -> _support2
> 
> r+, but revert the entity change

Done, pushed: https://hg.mozilla.org/integration/fx-team/rev/be0ae5640b90
Oops, forgot to update StringHelper for robocop tests. Done, pushed:
https://hg.mozilla.org/integration/fx-team/rev/11bdc7637af1
https://hg.mozilla.org/mozilla-central/rev/11bdc7637af1
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.