1025093 - Add Mapbox attribution to map UI on Edit Profile

Status: RESOLVED INVALID

(Participation Infrastructure :: Phonebook, defect)

Description

[William Reynolds [:williamr]]

The current map UI on the Edit Profile page has attributions for Leaflet and OpenStreetMap. We may also want to add an attribution for Mapbox, which powers the geolocation data.

Here is the current attribution text:
Leaflet | © OpenStreetMap contributors

For reference, here is the attribution text used on reps.mozilla.org:
© OpenStreetMap contributors, © Mapbox © OpenStreetMap | Improve this map Terms & Feedback © Mapbox © OpenStreetMap Improve this map

Note that the attribution text on reps.mozilla.org has some redundant parts. '© OpenStreetMap | Improve this map' appears twice.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

We previously had to hack leaflet to add attribution satisfying the OpenStreetMap guidelines. See bug 944750, bug 944758. 

As of the latest mapbox.js, the default attribution is satisfactory:
https://www.mapbox.com/blog/mapboxjs-v163/#Attribution

In other words, on maps where we previously hacked leaflet we can remove the hack and simply use the latest mapbox.js (for example, bug 1021035). On new maps we should just be sure to use the latest mapbox.js.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/db03f6449ae073450bfa9fb0dab1666702087780
[Fix bug 1025093] Fix mapbox attribution to map UI.

https://github.com/mozilla/mozillians/commit/3919ea1653138317d149ffac90d6ef6f26d3b269
Merge pull request #998 from johngian/1025093-fix-attribution

[Fix bug 1025093] Fix mapbox attribution to map UI.

Comment 3

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening for clarification
What is the expected text, the attributes in mapbox are redundant.

Actual:
© OpenStreetMap contributors, © Mapbox © OpenStreetMap | Improve this map Terms & Feedback © Mapbox © OpenStreetMap

Expected:
© OpenStreetMap contributors, © Mapbox © OpenStreetMap | Improve this map Terms & Feedback

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Hmm, this is only happening on stage, dev looks OK. I'll investigate.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/5f0bda4bb0a6dc27cbbc24e4f9246016418a7025
Revert "[Fix bug 1025093] Fix mapbox attribution to map UI."

This reverts commit db03f6449ae073450bfa9fb0dab1666702087780.

Automatic attribution fails when using Mozilla's mapbox IDs.
We need to investigate this further.

Comment 6

[Giorgos Logiotatidis [:giorgos]]

It seems that this happens only when using the ids for mozilla that mapbox issued. On our local environments we use example ids which work OK (and so does mozillians dev. I will file a bug to update those)

I already contacted mapbox for help. Meanwhile I'm reverting this change.

Comment 7

[Giorgos Logiotatidis [:giorgos]]

To clarify, this will not go out with the next release

Comment 8

[Giorgos Logiotatidis [:giorgos]]

I contacted Mapbox support:

"""
From the project, `mozilla-webprod.i81ph114` in the account it looks
like there are two street layers composed which is why the attribution
is showing up twice and is identical. From the data pane, "Spiffy
streets" is added as a layer on top of Mapbox streets. One idea might
be to use the data layer, 'mozilla-webprod.e91ef8b3' directly?
"""

I don't understand why we have two mapbox id's in the first place, one for the profile page alone and one generic. Maybe Wray can shed some light on this?

Comment 9

[Wray Bowling [:wbowling]]

This was perhaps already clarified sooner (via IRC?), but I'll explain it here just to be sure.

Each Mapbox account is made up of two halves:
A. Projects
B. Data

The relationships are built like so:
1. Each Project and Data gets a unique Mapbox ID
2. Projects are collections of 1 or more Data
3. Front-end displays can load Projects or Data Layers
4. Only Projects track usage analytics

Mozillians only one Data but has two Projects
D1. Visualization data layer
P1. A project loading just D1 (visualization layer)
P2. A project loading Mozilla's 'mozilla-webprod.e91ef8b3' that keeps analytics separate from mozilla.org that's only used for editing your profile.

The reason there are two styles is that there are two needs.
P1. the data visualization layer is much more distilled There are no labels on it — it's purpose is to give users a general and anonymized review of who lives where
P2. while editing your profile it's nice to not have all the data visualization noise in your way and clear labels. Even though your information will be obfuscated later, it makes sense to allow more specificity since you only are viewing yourself.

Comment 10

[Nikos Roussos [:comzeradd]]

This needs  upgrading mapboxjs and use tokens.

Comment 11

[Greg Cox [:gcox]]

This is an RFE specific to mozillians, which is decom'ed.
If this is found to pertain to people.mozilla.org then please open a new issue.