WebRTC record AEC button doesn't work when not started from the command line

RESOLVED FIXED in Firefox 32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ekr, Assigned: jesup)

Tracking

unspecified
mozilla33
x86
macOS
Points:
---

Firefox Tracking Flags

(firefox31 wontfix, firefox32 fixed, firefox33 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1024288 added a button to record AEC debug data

This doesn't do anything useful on a Mac when you run Nightly the usual way by clicking the icon in applications, presumably because it is trying to open files in "." and this isn't meaningful in this context. Running from the command line works.
Note: there's no pref to override the location.  If we need it, it's not hard to add.  Location is platform-specific and matches what we use as a default for webrtc.org trace logs - /tmp for linux/mac/bsd/etc, in %TEMP% on windows, and android is still an open question for AEC logs in general
Attachment #8440729 - Attachment is obsolete: true
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Decided for android at least we needed a pref for the AEC dump location, so gave it to all of them (simplifies things).  Android dumps will fail unless the user sets a directory (discussed with GCP).
Attachment #8440839 - Flags: review?(pkerr)
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Review of attachment 8440839 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp
@@ +111,5 @@
> +    aecLogDir = logFile;
> +    logFile.Append(default_log);
> +  }
> +#elif defined(ANDROID)
> +  // Special case: use callback to pipe to NSPR logging.

Change the comment: you are disabling for ANDROID unlike the webrtc_trace case.
Attachment #8440839 - Flags: review?(pkerr) → review+
https://hg.mozilla.org/mozilla-central/rev/85ae65b5aec9
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [webrtc-uplift]
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Approval Request Comment
[Feature/regressing bug #]: 1024288

See discussion there; they should be approved together
Attachment #8440839 - Flags: approval-mozilla-aurora?
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Aurora+
Attachment #8440839 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.