Closed
Bug 1025176
Opened 11 years ago
Closed 11 years ago
WebRTC record AEC button doesn't work when not started from the command line
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: ekr, Assigned: jesup)
Details
Attachments
(1 file, 1 obsolete file)
16.00 KB,
patch
|
pkerr
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1024288 added a button to record AEC debug data
This doesn't do anything useful on a Mac when you run Nightly the usual way by clicking the icon in applications, presumably because it is trying to open files in "." and this isn't meaningful in this context. Running from the command line works.
Assignee | ||
Comment 1•11 years ago
|
||
Note: there's no pref to override the location. If we need it, it's not hard to add. Location is platform-specific and matches what we use as a default for webrtc.org trace logs - /tmp for linux/mac/bsd/etc, in %TEMP% on windows, and android is still an open question for AEC logs in general
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8440729 -
Attachment is obsolete: true
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref
Decided for android at least we needed a pref for the AEC dump location, so gave it to all of them (simplifies things). Android dumps will fail unless the user sets a directory (discussed with GCP).
Attachment #8440839 -
Flags: review?(pkerr)
Comment 4•11 years ago
|
||
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref
Review of attachment 8440839 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp
@@ +111,5 @@
> + aecLogDir = logFile;
> + logFile.Append(default_log);
> + }
> +#elif defined(ANDROID)
> + // Special case: use callback to pipe to NSPR logging.
Change the comment: you are disabling for ANDROID unlike the webrtc_trace case.
Attachment #8440839 -
Flags: review?(pkerr) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Target Milestone: --- → mozilla33
Comment 6•11 years ago
|
||
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Whiteboard: [webrtc-uplift]
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref
Approval Request Comment
[Feature/regressing bug #]: 1024288
See discussion there; they should be approved together
Attachment #8440839 -
Flags: approval-mozilla-aurora?
Comment 8•11 years ago
|
||
Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref
Aurora+
Attachment #8440839 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•11 years ago
|
||
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
Whiteboard: [webrtc-uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•