1025176 - WebRTC record AEC button doesn't work when not started from the command line

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Eric Rescorla (:ekr)]

Bug 1024288 added a button to record AEC debug data

This doesn't do anything useful on a Mac when you run Nightly the usual way by clicking the icon in applications, presumably because it is trying to open files in "." and this isn't meaningful in this context. Running from the command line works.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Save AEC dumps in the default directory used for webrtc.log files

Note: there's no pref to override the location.  If we need it, it's not hard to add.  Location is platform-specific and matches what we use as a default for webrtc.org trace logs - /tmp for linux/mac/bsd/etc, in %TEMP% on windows, and android is still an open question for AEC logs in general

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Save AEC dumps in a specified directory depending on platform/pref

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Decided for android at least we needed a pref for the AEC dump location, so gave it to all of them (simplifies things).  Android dumps will fail unless the user sets a directory (discussed with GCP).

Comment 4

[Paul Kerr [:pkerr]]

Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Review of attachment 8440839 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp
@@ +111,5 @@
> +    aecLogDir = logFile;
> +    logFile.Append(default_log);
> +  }
> +#elif defined(ANDROID)
> +  // Special case: use callback to pipe to NSPR logging.

Change the comment: you are disabling for ANDROID unlike the webrtc_trace case.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85ae65b5aec9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/85ae65b5aec9

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Approval Request Comment
[Feature/regressing bug #]: 1024288

See discussion there; they should be approved together

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8440839 [details] [diff] [review]
Save AEC dumps in a specified directory depending on platform/pref

Aurora+

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d59ee55bd050