1025184 - Make ConstTwoByteChars a Range, like TwoByteChars

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

In bug 1023778 we noticed that ConstTwoByteChars is a RangedPtr and TwoByteChars is a Range. Both should be Ranges.

There are other RangedPtr types in CharacterEncoding.h, like TwoByteCharsZ.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Make ConstTwoByteChars a Range.

Made definition of ConstTwoByteChars almost same as TwoByteChars, with const.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a47af8c9a45

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8557921 [details] [diff] [review]
Make ConstTwoByteChars a Range.

Review of attachment 8557921 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

::: js/public/CharacterEncoding.h
@@ +158,4 @@
>    public:
> +    ConstTwoByteChars() : Base() {}
> +    ConstTwoByteChars(char16_t *aChars, size_t aLength) : Base(aChars, aLength) {}
> +    ConstTwoByteChars(const char16_t *aChars, size_t aLength) : Base(aChars, aLength) {}

Nit: can we remove the constructor that takes non-const chars?

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing! :D
and sorry for the long delay, I forgot to add me to CC list.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb655f416527

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb655f416527