102534 - typedNode serialization doesn't handle default namespace correctly

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Chase Tingley]

My fix for bug 97775 handles default namespaces in a bogus way -- it will
generate things that look like this:
  <:channel>
    <foo:prop>14</foo:prop>
  </:channel>

This is because for default namespace, |MakeQName()| will return success, but
|aNameSpacePrefix| will contain the empty string.  We need a check for this when
actually writing out the RDF.

http://lxr.mozilla.org/seamonkey/source/rdf/base/src/nsRDFXMLSerializer.cpp#488

Comment 1

[Chase Tingley]

-> me

Comment 2

[Chase Tingley]

Attachment: fix

Comment 3

[Chase Tingley]

Proposed solution: suck less and check for an empty namespace.

Waterson, Shaver: any chance you could take a look at this?  I'd like to get
this in for 0.9.5 since it's sort of a regression (as in, we used to handle this
ok, now we don't).  Thanks.

Comment 4

[Chris Waterson]

Comment on attachment 51534 [details] [diff] [review]
fix

zoiks! r/sr=waterson

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 51534 [details] [diff] [review]
fix

r=shaver.  Nice catch.

Comment 6

[Chris Waterson]

I'll get this checked in today.

Comment 7

[Chris Waterson]

Fix checked in.

Comment 8

[benc]

tever is not RDF QA anymore