1025340 - JavaScript strict warning: components/storage-mozStorage.js, line 248: assignment to undeclared variable encType

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[:aceman]

JavaScript strict warning:
file:///REF-OBJ-DIR/objdir-tb3/mozilla/dist/bin/components/storage-mozStorage.js,
line 248: assignment to undeclared variable encType

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8440179 [details] [diff] [review]
patch

Review of attachment 8440179 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/storage-mozStorage.js
@@ +245,5 @@
>  
>          // Throws if there are bogus values.
>          LoginHelper.checkLoginValues(login);
>  
>          [encUsername, encPassword, encType] = this._encryptLogin(login);

I think you can just move the |let| in front of [encUsername, encPassword, encType] and delete the line you changed.

Comment 3

[:aceman]

Attachment: patch v2

Yes, thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d948f572d49

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9d948f572d49