Closed Bug 1025340 Opened 7 years ago Closed 7 years ago

JavaScript strict warning: components/storage-mozStorage.js, line 248: assignment to undeclared variable encType

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file, 1 obsolete file)

1.19 KB, patch
aceman
: review+
Details | Diff | Splinter Review
JavaScript strict warning:
file:///REF-OBJ-DIR/objdir-tb3/mozilla/dist/bin/components/storage-mozStorage.js,
line 248: assignment to undeclared variable encType
Blocks: 826732
Attached patch patch (obsolete) — Splinter Review
Attachment #8440179 - Flags: review?(dolske)
Comment on attachment 8440179 [details] [diff] [review]
patch

Review of attachment 8440179 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/storage-mozStorage.js
@@ +245,5 @@
>  
>          // Throws if there are bogus values.
>          LoginHelper.checkLoginValues(login);
>  
>          [encUsername, encPassword, encType] = this._encryptLogin(login);

I think you can just move the |let| in front of [encUsername, encPassword, encType] and delete the line you changed.
Attachment #8440179 - Flags: review?(dolske) → review+
Attached patch patch v2Splinter Review
Yes, thanks.
Attachment #8440179 - Attachment is obsolete: true
Attachment #8440183 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9d948f572d49
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.