Closed Bug 1025349 Opened 6 years ago Closed 6 years ago

Potential out of bounds read in ccsnap_get_line_label and ccsnap_set_line_label

Categories

(Core :: WebRTC: Signaling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: erahm, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 749130][CID 749131])

Attachments

(1 file)

Off by one, test should be <, not <=:
  if ( btn > 0 && btn < MAX_CONFIG_LINES+1 ) {
Summary: Potential out of bounds read in ccsnap_get_line_label → Potential out of bounds read in ccsnap_get_line_label and ccsnap_set_line_label
Whiteboard: [CID 749130] → [CID 749130][CID 749131]
Easier to fix this than prove it's not used (and I'm pretty sure it's not).
Assignee: nobody → rjesup
Attachment #8440239 - Flags: review?(ethanhugg)
Comment on attachment 8440239 [details] [diff] [review]
fix error in ccsnap line label indexes

Review of attachment 8440239 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8440239 - Flags: review?(ethanhugg) → review+
https://hg.mozilla.org/mozilla-central/rev/95a1b1128c23
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.