1025553 - Allow gfxMatrix to be typedef'ed to Moz2D Matrix

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

I'd really like to be able to easily be able to switch between gfxMatrix and Moz2D's Matrix to test what the effect is of switching from double precision to single precision matrices. Perhaps we simply can't get away with doing this, but we should test what effect it has.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: change the names of the members of gfxMatrix to match the names of the members of Moz2D's Matrix

Happily Eclipse's refactoring tools worked very well on this.

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8440335 [details] [diff] [review]
change the names of the members of gfxMatrix to match the names of the members of Moz2D's Matrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/792d1ef07230

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/792d1ef07230

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: switch gfxMatrix from being a struct to being a class

Since Moz2D Matrix is a class.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8444444 [details] [diff] [review]
switch gfxMatrix from being a struct to being a class

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1afdcec1927

Comment 6

[Carsten Book [:Tomcat]]

(In reply to Jonathan Watt [:jwatt] from comment #5)
> Comment on attachment 8444444 [details] [diff] [review]
> switch gfxMatrix from being a struct to being a class
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f1afdcec1927

sorry had to back this out bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42439595&tree=Mozilla-Inbound

Comment 7

[Jonathan Watt [:jwatt]]

Yeah, I fixed that after a try push, but then misplaced my patch queue patch and took the r+'ed patch from this bug forgetting about the gfxBlur.h fix. Sorry. :(

Comment 8

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e791fc96512c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e791fc96512c

Comment 10

[Jonathan Watt [:jwatt]]

Attachment: part 4 - add some missing Matrix API to gfxMatrix

Comment 11

[Jonathan Watt [:jwatt]]

Attachment: part 6 - remove gfxMatrix::Multiply()

Comment 12

[Jonathan Watt [:jwatt]]

Attachment: give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert

Comment 13

[Jonathan Watt [:jwatt]]

Attachment: part 5 - add some missing gfxMatrix API to Moz2D Matrix

Comment 14

[Jonathan Watt [:jwatt]]

Attachment: part 3 - give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert

Comment 15

[Jonathan Watt [:jwatt]]

Comment on attachment 8454154 [details] [diff] [review]
part 3 - give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert

https://hg.mozilla.org/integration/mozilla-inbound/rev/343acb32cd03

Comment 16

[Jonathan Watt [:jwatt]]

Comment on attachment 8453777 [details] [diff] [review]
part 4 - add some missing Matrix API to gfxMatrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b79cf7e9268

Comment 17

[Jonathan Watt [:jwatt]]

Comment on attachment 8454116 [details] [diff] [review]
part 5 - add some missing gfxMatrix API to Moz2D Matrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d724821fb52

Comment 18

[Jonathan Watt [:jwatt]]

Comment on attachment 8453815 [details] [diff] [review]
part 6 - remove gfxMatrix::Multiply()

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb2ab91ddd34

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/343acb32cd03
https://hg.mozilla.org/mozilla-central/rev/1b79cf7e9268
https://hg.mozilla.org/mozilla-central/rev/2d724821fb52
https://hg.mozilla.org/mozilla-central/rev/fb2ab91ddd34

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jwatt, maybe it's time to close this bug?

Comment 21

[Jonathan Watt [:jwatt]]

Thanks!