Closed Bug 1025553 Opened 6 years ago Closed 1 year ago

Allow gfxMatrix to be typedef'ed to Moz2D Matrix

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(6 files, 1 obsolete file)

I'd really like to be able to easily be able to switch between gfxMatrix and Moz2D's Matrix to test what the effect is of switching from double precision to single precision matrices. Perhaps we simply can't get away with doing this, but we should test what effect it has.
Happily Eclipse's refactoring tools worked very well on this.
Attachment #8440335 - Flags: review?(bas)
Attachment #8440335 - Flags: review?(bas) → review+
Keywords: leave-open
Comment on attachment 8440335 [details] [diff] [review]
change the names of the members of gfxMatrix to match the names of the members of Moz2D's Matrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/792d1ef07230
Attachment #8440335 - Flags: checkin+
Since Moz2D Matrix is a class.
Attachment #8444444 - Flags: review?(bas)
Attachment #8444444 - Flags: review?(bas) → review+
Comment on attachment 8444444 [details] [diff] [review]
switch gfxMatrix from being a struct to being a class

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1afdcec1927
Attachment #8444444 - Flags: checkin+
(In reply to Jonathan Watt [:jwatt] from comment #5)
> Comment on attachment 8444444 [details] [diff] [review]
> switch gfxMatrix from being a struct to being a class
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f1afdcec1927

sorry had to back this out bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=42439595&tree=Mozilla-Inbound
Yeah, I fixed that after a try push, but then misplaced my patch queue patch and took the r+'ed patch from this bug forgetting about the gfxBlur.h fix. Sorry. :(
Attachment #8453777 - Flags: review?(bas) → review+
Attachment #8453815 - Flags: review?(bas) → review+
Attachment #8454114 - Attachment is obsolete: true
Attachment #8454114 - Flags: review?(bas)
Attachment #8454154 - Flags: review?(bas)
Attachment #8454116 - Flags: review?(bas) → review+
Attachment #8454154 - Flags: review?(bas) → review+
Comment on attachment 8454154 [details] [diff] [review]
part 3 - give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert

https://hg.mozilla.org/integration/mozilla-inbound/rev/343acb32cd03
Attachment #8454154 - Attachment description: give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert → part 3 - give gfxMatrix::Invert() the same semantics as Moz2D's Matrix::Invert
Attachment #8454154 - Flags: checkin+
Comment on attachment 8453777 [details] [diff] [review]
part 4 - add some missing Matrix API to gfxMatrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b79cf7e9268
Attachment #8453777 - Attachment description: add some missing Matrix API to gfxMatrix → part 4 - add some missing Matrix API to gfxMatrix
Attachment #8453777 - Flags: checkin+
Comment on attachment 8454116 [details] [diff] [review]
part 5 - add some missing gfxMatrix API to Moz2D Matrix

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d724821fb52
Attachment #8454116 - Attachment description: add some missing gfxMatrix API to Moz2D Matrix → part 5 - add some missing gfxMatrix API to Moz2D Matrix
Attachment #8454116 - Flags: checkin+
Comment on attachment 8453815 [details] [diff] [review]
part 6 - remove gfxMatrix::Multiply()

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb2ab91ddd34
Attachment #8453815 - Attachment description: remove gfxMatrix::Multiply() → part 6 - remove gfxMatrix::Multiply()
Attachment #8453815 - Flags: checkin+
The leave-open keyword is there and there is no activity for 6 months.
:jwatt, maybe it's time to close this bug?
Flags: needinfo?(jwatt)
Thanks!
Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(jwatt)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.