Closed Bug 1025581 Opened 7 years ago Closed 7 years ago

Add sync pref for the offline-apps.allow_by_default setting

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file)

While working on SeaMonkey bug 1019583 to make respective changes for the new preference introduced with bug 892488 I've noticed that there is a sync pref for the old browser.offline-apps.notify preference but not the new offline-apps.allow_by_default one. It seems illogical that one would be synced whereas the other isn't.

Reading through that bug report, there is no suggestion that the sync pref was omitted on purpose, thus I assume that it was just missed.
Attached patch Proposed patchSplinter Review
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8440360 - Flags: review?(ehsan)
Blocks: 892488
No longer depends on: 892488
Comment on attachment 8440360 [details] [diff] [review]
Proposed patch

We usually only sync prefs that are exposed in some preferences UI (about:config doesn't count).
Attachment #8440360 - Flags: review?(ehsan) → review-
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
(Quoting Honza Bambas (:mayhemer) from bug 933993 comment #1)
> We never had a UI for offline-apps.allow_by_default.  We have to add it.

Ok, so I take it that this should be revisited if and when bug 933993 introduces a UI for it.
You need to log in before you can comment on or make changes to this bug.