102559 - Focus bug with context menu

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Marco Pesenti Gritti]

When I show a gtk context menu on right button mouse click and then I close it
choosing an item on the menu or clicking on the page, the focus seem to remain
on the link.
This is reproducable with galeon and any other application based on gtkmozembed,
it's very bad for galeon because it breaks the focus handling when opening new
tabs from contexts.

Comment 1

[Vadim Berezniker]

Reporter, can you please elaborate on this?

Your description of the bug was not very clear.

Comment 2

[Marco Pesenti Gritti]

Sorry.
The only part I'm still able to reproduce atm is this:

1 Open a page in galeon
2 Use the context menu to open in a new window or tab
No status message is displayed when moving over links. This means that the
link_message callback is no more fired. When I click on the page all works fine
again.

To make this reproducable in TestGtkEmbed I should add a way to display a
context menu. Would this help ?
I'll also go through galeon bugs. I'm sure I've seen similar problems but I cant
find them now :(

Comment 3

[Vadim Berezniker]

OK. I see what you mean.
(I had tabs open in background so the bug only manifested when I would open new
windows)

Steps to reproduce.
1. Start galeon
2. Right click on a link and open in a new window
3. Try moving your mouse over the links and nothing happens

confirming on linux trunk 2002032300

Comment 4

[Aaron Brick]

for reference, the galeon issue:

http://bugzilla.gnome.org/show_bug.cgi?id=61109

Comment 5

[Andrej Czapszys]

Attachment: Make GTK2 toplevel focus handlers act like the GTK1 versinons

The GTK2 port seems to have introduced a simple bug based on the GTK1 comment:
   // connect to the toplevel focus out events for the child

The top level here appears to have meant the top level mozilla embed, not the 
top level window.  This patch fixes the result of this confusing comment.

Here's what happens in the current code:
* The top level window receives a focus in/out event and calls the 
RootFocusController->SetActive(PR_TRUE/FALSE) for each GtkMozEmbed in the 
current window.
* SetActive causes the last tab opened to grab the focus.
* TAB's at this point cause the focus to walk the focusable nodes of the last
opened tab, rather than the current tab's document.

The GTK1 embed only does a SetActive on the currently focused GtkMozEmbed's
Root focus controller and maintains focus in the currently focused document.

This patch replaces the GTK2 version's NS_ACTIVATE handling with the GTK1's 
version's.

Comment 6

[Marco Pesenti Gritti]

The patch seem to try to address the same problem of 210373

Comment 7

[Christopher Blizzard (:blizzard)]

This is programming by side effect.  There are already focus handlers for the
child widget, which are attached seperately.  The code in question is actually
set up to listen for focus events on the toplevel window.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Embedding: GTK Widget isn't a thing, closing.