1025609 - Unable to add a Gmail calendar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[:gerard-majax]

STR:
 0. Add a Google account in Calendar app
 1. Authorize the app when OAuth flow asks

Expected:
 Calendar is added

Actual:
 An error toaster pops, stating that there was an error. GMail calendar is not added.

There is this line in logcat:
> E/GeckoConsole( 3381): [JavaScript Error: "Error: Script file not found: ./shared/js/uuid.js?time=1402828586824" {file: "app://calendar.gaiamobile.org/js/caldav_worker.js?time=1402828586487" line: 16}]

This makes the Calendar app completely unusable for a GMail account.

Comment 1

[:gerard-majax]

> $ sha1sum profile/webapps/calendar.gaiamobile.org/application.zip application.zip 
> e36b01f4f3efe6b3b00dedbed0a90783e1ff6480  profile/webapps/calendar.gaiamobile.org/application.zip
> e36b01f4f3efe6b3b00dedbed0a90783e1ff6480  application.zip
> alex@portable-alex:~/codaz/B2G/gaia$ unzip -l application.zip | grep uuid.js
>      6934  1970-01-01 01:00   shared/js/uuid.js

The file is in the zip.

Comment 2

[:gerard-majax]

I'm reproducing this on my Nexus S and on my Flame devices.

Comment 3

[:gerard-majax]

In logcat, after cleaning gaia's git clone, rebuilding and reflashing system partition:

> E/GeckoConsole(  419): [JavaScript Error: "TypeError: pull is undefined" {file: "app://calendar.gaiamobile.org/gaia_build_defer_index.js" line: 476}]
> E/GeckoConsole(  419): [JavaScript Error: "Error: Script file not found: ./shared/js/uuid.js?time=1402835965579" {file: "app://calendar.gaiamobile.org/js/caldav_worker.js?time=1402835965386" line: 16}]

Comment 4

[Kevin Grandon :kgrandon]

I think I broke this, will take.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Alex - just got your message, then you signed off. I think I've found the issue, seems we manually construct the path, and I forgot to test this part. (We are currently working on some integration tests for this feature).

If you do manage to have a similar patch, we can land yours, or you could review this one perhaps? Sorry about the breakage.

Comment 6

[:gerard-majax]

Comment on attachment 8440530 [details] [review]
Github pull request

This does fix the issue when testing in mulet !

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8440530 [details] [review]
Github pull request

Thanks, and sorry about that again. The syntax might be able to be a bit better, but I'll just go with the one-liner for now for r=me.

Comment 8

[Kevin Grandon :kgrandon]

https://github.com/mozilla-b2g/gaia/commit/2b7c14cf51c935d96e28d9bdc7adffd087b041d7

Comment 9

[Kevin Grandon :kgrandon]

This should be present in 2.0 now, or soon and is pretty bad. We should definitely block.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/271eed7067e9a629f67b5c049ea4ed969fa2b594

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

I can still not add a calendar on v2.0 as of git commit 0f254c92.  I did not get an error toaster as this bug described.  See my description in bug 1026667.

Comment 13

[Edward Chen[:edchen]]

[Environment]
Gaia      0910be495385d90acdeaddbeaf1fba315aff57b0
Gecko     https://hg.mozilla.org/mozilla-central/rev/7883d8e9f210
BuildID   20140715160202
Version   33.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 14

[Mike Lien[:mlien]]

verify with Flame KK v180 + v2.0 gaia/gecko, it's fine
Gaia      7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/13e04ab68621
BuildID   20140914162307
Version   32.0

Comment 15

[Elie]

Attachment: VIDEO0094_clip_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2