Closed
Bug 1025673
Opened 12 years ago
Closed 12 years ago
link broken : https://www.mozilla.org/about/policies/
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: 1antoinechevrier1, Assigned: sgarrity)
Details
(Whiteboard: [kb=1414972] )
Attachments
(1 file)
|
14.22 KB,
patch
|
pmac
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140608211810
Steps to reproduce:
Go to https://www.mozilla.org/hacking/module-ownership.html
Then click to the link "POLICY" (see top left of inside content HOME / ABOUT MOZILLA)
Actual results:
Then it jumps to a 404 page.
Expected results:
Go to a POLICY page
Comment 1•12 years ago
|
||
Please update the Policies link in the bookmark to point to http://www.mozilla.org/en-US/about/governance/policies/
Updated•12 years ago
|
Whiteboard: [kb=1414972]
| Assignee | ||
Comment 2•12 years ago
|
||
The attached patch updates the /about/policies/ links to point to /about/governance/policies/. It also removes two files that are not accessible due to existing redirects.
Perhaps we should follow up patch with a bedrock PR that adds the following redirects:
from /about/policies/ to /about/governance/policies/
from /about/policies/participation.html to /about/governance/policies/participation/
That doesn't need to block this patch though.
Attachment #8442461 -
Flags: review?(pmac)
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → steven
Updated•12 years ago
|
Attachment #8442461 -
Flags: review?(pmac) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Applied the patch in mozilla.org trunk in r129690. Leaving the bug open for the bedrock redirects.
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 4•12 years ago
|
||
We do have a redirect from /about/policies/ -> /about/governance/policies/ but I think it is being bypassed due to the /en-US/ prefix.
https://github.com/mozilla/bedrock/blob/master/etc/httpd/global.conf#L587
I think this should work fine if we add the usual /(\w{2,3}(?:-\w{2})?/)? locale section check to the beginning of the redirect. pmac, make sense?
Flags: needinfo?(pmac)
Comment 5•12 years ago
|
||
Agreed. Looks like all three of those redirects in that group could use this treatment.
Flags: needinfo?(pmac)
| Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Paul McLanahan [:pmac] from comment #5)
> Agreed. Looks like all three of those redirects in that group could use this
> treatment.
Done in PR 2170: https://github.com/mozilla/bedrock/pull/2107
I did these blind, as my local setup for testing such redirects isn't working.
Comment 7•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/8c7cab1e192d01156902ef12e82feb6406d4aaca
Make policies retirect locale-prefix aware
Bug 1025673
| Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•