/tour should have different UITour PageID than /firstrun

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Unfocused, Assigned: agibson)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1411467])

Attachments

(1 attachment)

So, it turns out we would like to differentiate whether someone is seeing the tour via the /tour URL (manually opened via Firefox's help menu) or the /whatsnew URL (opened automatically).

So when the tour is seen via the /tour URL, it should specify a different PageID to the mozUITour API. Suggestion:

/whatsnew: australis-tour-firstrun-29-release (ie, no change)
/tour: australis-tour-firstrun-29-release-nav
(Assignee)

Comment 1

4 years ago
Thanks Blair, will pick this up
Whiteboard: [kb=1411467]
(Assignee)

Comment 2

4 years ago
Also, I assume you mean /firstrun (which is the variation also seen at /tour)
Summary: /tour should have different UITour PageID than /whatsnew → /tour should have different UITour PageID than /firstrun
(Assignee)

Updated

4 years ago
Assignee: nobody → agibson
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 8441298 [details] [review]
GitHub pull request

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/5263cff65b539de7afc9afb772ff7709615f1f6e
[fix bug 1025701] /tour should have different UITour PageID than /firstrun

https://github.com/mozilla/bedrock/commit/247b2eda79388e16ca8f285237a2113bda0cd859
Merge pull request #2103 from alexgibson/bug-1025701-tour-different-page-id-than-firstrun

[fix bug 1025701] /tour should have different UITour PageID than /firstrun

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.