1025723 - [LockScreen][System] Change the old locking events with new window events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

The old 'unlock', 'will-unlock' and 'lock' events, should be replaced with 'lockscreenwindow-closed', 'lockscreenwindow-closing' and 'lockscreenwindow-opened'.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

I've changed the old events with new ones, and the patch passed TBPL except connection timeouts that also occur at the other PRs:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=1db5daea328add7bf54944626c1d1f2f69638933

It also passed all Travis tests:

https://travis-ci.org/mozilla-b2g/gaia/builds/27658223

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8441802 [details] [review]
Patch

Thanks

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/16bfd4941319545366c60d7688e88bbcd3f0cb41

Comment 4

[Dave Hylands [:dhylands]]

Other places that depend on the lock/unclock notifications:

1 - USB Mass Storage - seems to have been fixed

2 - AdbController - http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#429

Does the new app generate lockscreen.locked and lockscreen.unlocked events?

This probably also affects bug 1026555