If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Dolphin] adb unavailable on user build

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: pehrsons, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
I have just flashed a VARIANT=user build on Dolphin and enabled adb in the developer menu but adb is unavailable on the Dolphin:

$ adb devices
List of devices attached 
0123456789ABCDEF	unauthorized

$ adb shell
error: device unauthorized. Please check the confirmation dialog on your device.


Seems like adb is waiting for user authorization of the adb session. On Android you'd get a dialogue on the device to authorize adb, but Firefox OS doesn't provide the same functionality.

I believe we are controlling adb access by turning it off when a lock screen is active instead.
(Reporter)

Updated

3 years ago
Blocks: 981983
(Reporter)

Comment 1

3 years ago
Kai-Zhen, what is the desired UX regarding remote debugging or adb on a user build? I.e., is it supposed to be available? Is it supposed to engage the user with a dialog that needs approval?

I take back what I said about Firefox OS not providing the dialog functionality in the description. I have seen it on other devices :)
Flags: needinfo?(kli)
(Reporter)

Comment 2

3 years ago
This might actually be fixed for the dolphin already, but it'd be good to know how the UX is supposed to be anyway.
I think we should have a design to let the user know and confirm when remote debugging or adb on a user build. But I don't have a good idea now. I'll ni our UX for some suggestion.

Jenny, do you have any idea? How should we handle this requirement in our setting?
Flags: needinfo?(kli) → needinfo?(jelee)

Comment 4

3 years ago
Hi Kai-Zhen, it seems we need a dialog for confirmation. Do you have a reference screenshot on this? Thanks!
Flags: needinfo?(jelee)
(Reporter)

Comment 5

3 years ago
I think there is a confirmation dialog already, but it's been patched away here for some reason. I was just curious on the current UX behavior, so I can verify that I see the correct thing.
(Reporter)

Comment 6

3 years ago
This has now been fixed on dolphin. adb is available on user builds.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.