XML content sink speedup and cleanup...

RESOLVED FIXED in mozilla0.9.6

Status

()

Core
XML
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Trunk
mozilla0.9.6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [HAVE FIX])

Attachments

(4 attachments)

(Assignee)

Description

17 years ago
The namespace related methods in nsXMLContentSink copy too much string data, and
also require the caller to copy strings when there's no need to do that, patch
coming up.
(Assignee)

Comment 1

17 years ago
Created attachment 51576 [details] [diff] [review]
Proposed fix.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.6
(Assignee)

Comment 2

17 years ago
Created attachment 51584 [details] [diff] [review]
Even better fix.
Comment on attachment 51584 [details] [diff] [review]
Even better fix.

>+  if (nameSpaceID == kNameSpaceID_Unknown) {
>+    //    namespace error
>+  }
>+
Need an assertion?

Other than that, r=peterv provided the JST Review Simulacrum r'ed it :P.
Attachment #51584 - Flags: review+
(Assignee)

Comment 4

17 years ago
Hmm, that part was not supposed to be in the patch, ignore that piece of the
patch :-) I'll attach a new patch w/o that change. Thanks for the review.
(Assignee)

Comment 5

17 years ago
Created attachment 51594 [details] [diff] [review]
Same as above w/o a change that wasn't supposed to be there.
(Assignee)

Updated

17 years ago
Attachment #51594 - Flags: review+
(Assignee)

Comment 6

17 years ago
Created attachment 53700 [details] [diff] [review]
Fix a typo in the above patch.

Comment 7

17 years ago
Comment on attachment 53700 [details] [diff] [review]
Fix a typo in the above patch.

sr=waterson
Attachment #53700 - Flags: superreview+
(Assignee)

Comment 8

17 years ago
This was fixed a while back.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

16 years ago
QA Contact: petersen → rakeshmishra
You need to log in before you can comment on or make changes to this bug.