102588 - Error in reporting modern theme author (id display "app_author}") (venkman related)

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Daniele Nicolodi]

In mozilla/extensions/venkman/resources/skin/contents.rdf the theme author is
specified as "app_author}" and not as "mozilla.org" (?).

Comment 1

[Daniele Nicolodi]

Attachment: Proposed patch that set author to "mozilla.org"

Comment 2

[Boris Zbarsky [:bzbarsky]]

Over to venkman

Comment 3

[Robert Ginda]

r=rginda

hyatt, what do you think about this one?  I would guess that letting the last
package installed dictate the author (and presumably the name) of the skin is
not a good idea.

Comment 4

[Robert Ginda]

To summarize, venkman had listed "app_author}" as the author of it's version of
the modern skin, which caused the Edit->Prefs->Apperance->Themes entry for
Modern to display this string.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 51579 [details] [diff] [review]
Proposed patch that set author to "mozilla.org"

sr=shaver

Comment 6

[David Hyatt]

r=hyatt

Comment 7

[Robert Ginda]

Fix checked in.

Comment 8

[Brendan Eich [:brendan]]

so should there be a spin-off bug?

/be

Comment 9

[Robert Ginda]

bug 102768 filed.

Comment 10

[Patty Mac]

Verified the patch